Details

Reviewers

Group Reviewers

Commits

rDCORE4a20ead81216: api/async: add support for content negotiation

Summary

For the content negotiation to work, we expect handler functions to
return straight data structures instead of Response objects so we can
handle the serialization in the "main" middleware (error_middleware,
which should probably be renamed).

It should still work with server handler implementations that do
produce Response object, but without the content negotitation feature
available then.

Related to T1871

Diff Detail

Repository

rDCORE Foundations and core functionalities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jul 4 2019, 12:18 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 4 2019, 12:18 PM

This diff is a WIP since it uses the aiohttp_utils python package that has no debian package available for now.

douardda retitled this revision from api/async: add support for content negotiation to [WIP] api/async: add support for content negotiation.Jul 4 2019, 12:19 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/241/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/241/console

Harbormaster failed remote builds in B6681: Diff 5668!Jul 4 2019, 12:19 PM

add forgotten patch of requirements

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/242/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/242/console

Harbormaster failed remote builds in B6682: Diff 5669!Jul 4 2019, 12:23 PM

updated and rebased

fix

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/246/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/246/console

Harbormaster failed remote builds in B6740: Diff 5718!Jul 9 2019, 6:09 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/247/ for more details.

Harbormaster completed remote builds in B6741: Diff 5719.Jul 9 2019, 6:10 PM

I've published a new version of aiohttp_utils so this diff is no longer a wip

rebased

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/252/ for more details.

Harbormaster completed remote builds in B6747: Diff 5725.Jul 10 2019, 10:32 AM

rebased

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/258/ for more details.

Harbormaster completed remote builds in B6757: Diff 5735.Jul 10 2019, 12:05 PM

The debian package for aiohttp_utils is now available on debian.softwareheritage.org

olasd accepted this revision.Jul 11 2019, 3:42 PM

This revision is now accepted and ready to land.Jul 11 2019, 3:42 PM

rework a bit the commit message

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/259/ for more details.

Harbormaster completed remote builds in B6811: Diff 5792.Jul 11 2019, 3:47 PM

rebased

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/262/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/262/console

Harbormaster failed remote builds in B6865: Diff 5826!Jul 15 2019, 12:10 PM

rework a bit the diff so that

it behaves more consistently wrt aiohttp: handlers are expected to
return Response objects, but when content negotiation is available (i.e.
when aiohttp_utils is present), handlers must return an aiohttp_utils.Response
object for the content negotiation to work properly.

Otherwise it should fall back to the former behavior (no content nego, always
render results as msgpack by default).

Harbormaster failed remote builds in B6866: Diff 5827!Jul 15 2019, 12:31 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/263/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/263/console