Page MenuHomeSoftware Heritage

Exclude dates outside the range supported by our data model.
ClosedPublic

Authored by vlorentz on Jul 26 2019, 2:00 PM.

Details

Diff Detail

Repository
rDJNL Journal infrastructure
Branch
exclude-dates
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7042
Build 9918: tox-on-jenkinsJenkins
Build 9917: arc lint + arc unit

Event Timeline

ardumont added inline comments.
swh/journal/replay.py
36

Urgh, maybe make that return the new list of revisions instead of mutating the input...
That'd be clearer.

40

Please, add a docstring to explicit the range.
People are not all python/postgresql experts so they won't understand immediately what those boundaries are ;)

57

Excluding revision with invalid date fields or anything clearer if you have ;)

  • rebase
  • more doc
  • more tests
  • better warning
  • copy instead of in-place edits
This revision is now accepted and ready to land.Aug 6 2019, 3:34 PM
This revision was automatically updated to reflect the committed changes.