Paths

Table of Contentst

Differential D1775

Exclude dates outside the range supported by our data model.
ClosedPublic
Actions

Authored by vlorentz on Jul 26 2019, 2:00 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDJNLcc062eabc7ae: Exclude dates outside the range supported by our data model.

Summary

Depends on D1773.

Related: T1339

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jul 26 2019, 2:00 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 26 2019, 2:00 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/203/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/203/console

Harbormaster failed remote builds in B7039: Diff 5998!Jul 26 2019, 2:03 PM

fix test data

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/204/ for more details.

Harbormaster completed remote builds in B7042: Diff 6001.Jul 26 2019, 2:25 PM

vlorentz edited the summary of this revision. (Show Details)Jul 26 2019, 4:36 PM

vlorentz added a child revision: D1777: Limit replayer output to 1 message/min..Jul 26 2019, 4:47 PM

ardumont added a subscriber: ardumont.Aug 6 2019, 2:23 PM

ardumont added inline comments.

swh/journal/replay.py
36	Urgh, maybe make that return the new list of revisions instead of mutating the input... That'd be clearer.
40	Please, add a docstring to explicit the range. People are not all python/postgresql experts so they won't understand immediately what those boundaries are ;)
67	`Excluding revision with invalid date fields` or anything clearer if you have ;)

rebase
more doc
more tests
better warning
copy instead of in-place edits

vlorentz marked 3 inline comments as done.Aug 6 2019, 3:22 PM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/214/ for more details.

Harbormaster completed remote builds in B7172: Diff 6143.Aug 6 2019, 3:26 PM

Thanks ;)

This revision is now accepted and ready to land.Aug 6 2019, 3:34 PM

Closed by commit rDJNLcc062eabc7ae: Exclude dates outside the range supported by our data model. (authored by vlorentz). · Explain WhyAug 6 2019, 3:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

journal/

117 lines

tests/

53 lines

Diff 6144

swh/journal/replay.py

Loading...

swh/journal/tests/conftest.py

Loading...