Page MenuHomeSoftware Heritage

Exclude dates outside the range supported by our data model.
ClosedPublic

Authored by vlorentz on Jul 26 2019, 2:00 PM.

Details

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jul 26 2019, 2:00 PM
vlorentz updated this revision to Diff 6001.Jul 26 2019, 2:22 PM

fix test data

vlorentz edited the summary of this revision. (Show Details)Jul 26 2019, 4:36 PM
ardumont added inline comments.
swh/journal/replay.py
37

Urgh, maybe make that return the new list of revisions instead of mutating the input...
That'd be clearer.

41

Please, add a docstring to explicit the range.
People are not all python/postgresql experts so they won't understand immediately what those boundaries are ;)

68

Excluding revision with invalid date fields or anything clearer if you have ;)

vlorentz updated this revision to Diff 6143.EditedAug 6 2019, 3:22 PM
  • rebase
  • more doc
  • more tests
  • better warning
  • copy instead of in-place edits
vlorentz marked 3 inline comments as done.Aug 6 2019, 3:22 PM
ardumont accepted this revision.Aug 6 2019, 3:34 PM

Thanks ;)

This revision is now accepted and ready to land.Aug 6 2019, 3:34 PM
This revision was automatically updated to reflect the committed changes.