Page MenuHomeSoftware Heritage
Differential D1752

Remove fallback when aiohttp_utils is not installed.
ClosedPublic
Actions

Authored by vlorentz on Jul 19 2019, 3:28 PM.

Details

Reviewers
douardda
ardumont
Group Reviewers
Reviewers
Commits
rDCORE02faef83a21e: Remove fallback when aiohttp_utils is not installed.
Summary

from aiohttp import Response raises an ImportError.

Diff Detail

Repository
rDCORE Foundations and core functionalities
Branch
aiohttp_utils-fallback
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6937
Build 9745: tox-on-jenkinsJenkins
Build 9744: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jul 19 2019, 3:28 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 19 2019, 3:28 PM
swh-public-ci added a comment.Jul 19 2019, 3:30 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/268/ for more details.

Harbormaster completed remote builds in B6937: Diff 5901.Jul 19 2019, 3:30 PM
ardumont added subscribers: douardda, ardumont.Aug 6 2019, 1:25 PM

I'm not sure about this back and forth... This was added not so long ago... See D1688

Might be discuss this with @douardda when he gets back

olasd added a subscriber: olasd.Aug 20 2019, 11:20 AM

A smaller change would be importing Response from aiohttp.web instead of just aiohttp.

In that case it'd be nice to add a test for this code path.

douardda added a comment.Aug 28 2019, 3:31 PM

FTR, and IIRC, I did write this fallback stuff because aiohttp_utils was not available on stretch.

Since we do have a deb now, I'm ok with this simplification.

douardda accepted this revision.Aug 29 2019, 1:30 PM
This revision is now accepted and ready to land.Aug 29 2019, 1:30 PM
ardumont accepted this revision.Aug 29 2019, 1:31 PM
vlorentz updated this revision to Diff 6520.Sep 2 2019, 4:11 PM

rebase

This revision was landed with ongoing or failed builds.Sep 2 2019, 4:11 PM
Closed by commit rDCORE02faef83a21e: Remove fallback when aiohttp_utils is not installed. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B7587: Diff 6520!Sep 2 2019, 4:11 PM
swh-public-ci added a comment.Sep 2 2019, 4:12 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/280/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/280/console

Revision Contents
Changeset List

PathSize
swh/
core/
api/
32 lines

Diff 5901

View Options

swh/core/api/asynchronous.py

Loading...
About · Developer information · Legal