Page MenuHomeSoftware Heritage

Fix crash when calling __contains__/get/check/delete with composite obj ids
ClosedPublic

Authored by vlorentz on Jul 13 2022, 12:02 PM.

Diff Detail

Repository
rDOBJS Object storage
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 30424
Build 47560: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 47559: arc lint + arc unit

Event Timeline

vlorentz added 1 blocking reviewer(s): olasd.

Build has FAILED

Patch application report for D8122 (id=29346)

Rebasing onto 2e642be3ec...

Current branch diff-target is up to date.
Changes applied before test
commit 602780e929e74730579e59258ce9604664511773
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jul 13 11:49:29 2022 +0200

    Fix crash when calling __contains__/get/check/delete with composite obj ids

Link to build: https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/172/
See console output for more information: https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/172/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 13 2022, 12:03 PM
Harbormaster failed remote builds in B30423: Diff 29346!

Build is green

Patch application report for D8122 (id=29347)

Rebasing onto 2e642be3ec...

Current branch diff-target is up to date.
Changes applied before test
commit 6f45e35cdb6100a20efb2dedc23aca745506667d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jul 13 11:49:29 2022 +0200

    Fix crash when calling __contains__/get/check/delete with composite obj ids

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/173/ for more details.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 22 2022, 11:28 AM
This revision was automatically updated to reflect the committed changes.