delete with composite obj ids
ClosedPublic
Actions

Authored by vlorentz on Jul 13 2022, 12:02 PM.

Details

Reviewers

olasd
ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T4402: Pass dict of hashes instead of single sha1 to objstorage.get()

Commits

rDOBJS6f45e35cdb61: Fix crash when calling __contains__/get/check/delete with composite obj ids

Diff Detail

Repository

rDOBJS Object storage

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jul 13 2022, 12:02 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 13 2022, 12:02 PM

vlorentz added a reviewer: olasd.Jul 13 2022, 12:03 PM

vlorentz added 1 blocking reviewer(s): olasd.

Build has FAILED

Patch application report for D8122 (id=29346)

Rebasing onto 2e642be3ec...

Current branch diff-target is up to date.

Changes applied before test

commit 602780e929e74730579e59258ce9604664511773
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jul 13 11:49:29 2022 +0200

    Fix crash when calling __contains__/get/check/delete with composite obj ids

Link to build: https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/172/
See console output for more information: https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/172/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 13 2022, 12:03 PM

Harbormaster failed remote builds in B30423: Diff 29346!

fix py3.7 support

Build is green

Patch application report for D8122 (id=29347)

Rebasing onto 2e642be3ec...

Current branch diff-target is up to date.

Changes applied before test

commit 6f45e35cdb6100a20efb2dedc23aca745506667d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jul 13 11:49:29 2022 +0200

    Fix crash when calling __contains__/get/check/delete with composite obj ids

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/173/ for more details.

Harbormaster completed remote builds in B30424: Diff 29347.Jul 13 2022, 12:21 PM

vlorentz requested review of this revision.Jul 13 2022, 12:21 PM

vlorentz added a child revision: D8127: Call objstorage.content_get() with a HashDict instead of single hash.Jul 18 2022, 3:24 PM

vlorentz added a child revision: D8135: rehash: Call objstorage.content_get() with a HashDict instead of single hash.Jul 19 2022, 2:39 PM

vlorentz added a child revision: D8137: Call objstorage.get() with a HashDict instead of single hash.Jul 19 2022, 3:07 PM

vlorentz added a child revision: D8138: Update for swh-objstorage >= 2.0.0.Jul 19 2022, 3:14 PM

vlorentz added a task: T4402: Pass dict of hashes instead of single sha1 to objstorage.get().Jul 19 2022, 3:16 PM

ardumont accepted this revision.Aug 22 2022, 11:19 AM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 22 2022, 11:28 AM

Closed by commit rDOBJS6f45e35cdb61: Fix crash when calling __contains__/get/check/delete with composite obj ids (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.