Page MenuHomeSoftware Heritage

Call objstorage.get() with a HashDict instead of single hash
Needs ReviewPublic

Authored by vlorentz on Tue, Jul 19, 3:07 PM.

Details

Summary

Hash dicts are now prefered by swh-objstorage, in order to support
individual hash collisions.

Test Plan

Depends on D8122

Diff Detail

Event Timeline

Build has FAILED

Patch application report for D8137 (id=29380)

Could not rebase; Attempt merge onto c07d934aef...

Updating c07d934..251cf7a
Fast-forward
 swh/vault/cache.py            | 15 ++++++++-------
 swh/vault/cookers/git_bare.py |  2 +-
 swh/vault/tests/test_cache.py |  5 ++---
 swh/vault/to_disk.py          |  2 +-
 4 files changed, 12 insertions(+), 12 deletions(-)
Changes applied before test
commit 251cf7a91b2c366b7e255aa2e918e1cdc887f842
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jul 19 15:06:06 2022 +0200

    Call objstorage.get() with a HashDict instead of single hash
    
    Hash dicts are now prefered by swh-objstorage, in order to support
    individual hash collisions.

commit ceb26750ad9ddaeb8d725f18051f6f34038f3672
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jul 19 14:55:07 2022 +0200

    Fix mypy error
    
    This is not a runtime issue, because when the supplied mode is DentryPerms.symlink,
    the target is only used passed to os.symlink, which does allow str too.

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/243/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/243/console

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Jul 19, 3:09 PM
Harbormaster failed remote builds in B30454: Diff 29380!