Differential D6013

assets/guided_tour: Improve tour and fix redirection bug
ClosedPublic
Actions

Authored by anlambert on Jul 21 2021, 2:13 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3437: Review guided tour and collect feedback from testers

Commits

rDWAPPS481647f863a6: assets/guided_tour: Improve tour and fix redirection bug

Summary

Reword some sentences and add step showing SWHID with lines qualifer.

Fix redirection at end of tour when started from homepage.

Related to T3437

Diff Detail

Repository

rDWAPPS Web applications

Branch

guided-tour-improvements

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 22698
Build 35398: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 35397: arc lint + arc unit

Event Timeline

anlambert created this revision.Jul 21 2021, 2:13 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 21 2021, 2:13 PM

Build is green

Patch application report for D6013 (id=21722)

Rebasing onto 914c19e314...

Current branch diff-target is up to date.

Changes applied before test

commit e946f25ad0da729b69f8a1f26bc64ea3eb5c20ce
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 20 16:26:59 2021 +0200

    assets/guided_tour: Improve tour and fix redirection bug
    
    Reword some sentences and add step showing SWHID with lines qualifer.
    
    Fix redirection at end of tour when started from homepage.
    
    Related to T3437

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/980/ for more details.

Harbormaster completed remote builds in B22690: Diff 21722.Jul 21 2021, 2:31 PM

anlambert requested review of this revision.Jul 21 2021, 2:31 PM

lgtm

one non-blocking suggestion inline.

assets/src/bundles/guided_tour/guided-tour-steps.yaml
89	i liked it as source code but as you wish ;) Also that stays consistent with the other "source code" mentioned below.

This revision is now accepted and ready to land.Jul 21 2021, 3:11 PM

anlambert added a subscriber: moranegg.Jul 21 2021, 3:26 PM

anlambert added inline comments.

assets/src/bundles/guided_tour/guided-tour-steps.yaml
89	I guess @moranegg here was refering to source as the place the code was captured from. I will rephrase into: You can go directly to the place the source code was captured.

Address @ardumont comment.

*thumbs up* ;)

Build is green

Patch application report for D6013 (id=21730)

Rebasing onto 914c19e314...

Current branch diff-target is up to date.

Changes applied before test

commit 481647f863a62d0a6f28fadca9e6653851f6a398
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 20 16:26:59 2021 +0200

    assets/guided_tour: Improve tour and fix redirection bug
    
    Reword some sentences and add step showing SWHID with lines qualifer.
    
    Fix redirection at end of tour when started from homepage.
    
    Related to T3437

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/981/ for more details.

Harbormaster completed remote builds in B22698: Diff 21730.Jul 21 2021, 5:51 PM

Closed by commit rDWAPPS481647f863a6: assets/guided_tour: Improve tour and fix redirection bug (authored by anlambert). · Explain WhyJul 21 2021, 5:58 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS481647f863a6: assets/guided_tour: Improve tour and fix redirection bug.