Extract the object storage to its own package and do the required modifications on the imports
ClosedPublic
Actions

Authored by qcampos on Jun 23 2016, 2:30 PM.

Details

Reviewers

olasd
zack
ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T460: Extract the objstorage component from storage module to an independent module

Commits

rDSTOC2cf3a5a3fe2f: Extract http servers common code to swh.objstorage for dependencies
rDSTOC92e6cd845775: Update debian packaging configuration files
rDSTOC3ab3d3dd27f1: Remove objstorage scripts
rDSTOC7a0369f3ddf9: Extract the object storage to its own package and do the required modifications…
R65:3ab3d3dd27f1: Remove objstorage scripts
R65:2cf3a5a3fe2f: Extract http servers common code to swh.objstorage for dependencies
R65:92e6cd845775: Update debian packaging configuration files
R65:7a0369f3ddf9: Extract the object storage to its own package and do the required modifications…
rDARC14bb2ee8cb6a: Extract the object storage to its own package and do the required modifications…
rDSTO92e6cd845775: Update debian packaging configuration files
rDSTO3ab3d3dd27f1: Remove objstorage scripts
rDSTO2cf3a5a3fe2f: Extract http servers common code to swh.objstorage for dependencies
rDSTO7a0369f3ddf9: Extract the object storage to its own package and do the required…

Summary

Also, remove the objstorage-related module swh.storage.checker to put in into swh.objstorage.checker.

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 241
Build 358: Software Heritage Python tests
Build 357: arc lint + arc unit

Event Timeline

qcampos updated this revision to Diff 208.Jun 23 2016, 2:30 PM

qcampos retitled this revision from to Extract the object storage to its own package and do the required modifications on the imports.

qcampos updated this object.

qcampos edited the test plan for this revision. (Show Details)

qcampos added reviewers: olasd, zack.

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 23 2016, 2:30 PM

The tests doesn't works (although make test in swh.storage works in local) because of :

======================================================================
ERROR: Failure: ImportError (No module named 'swh.objstorage')
----------------------------------------------------------------------

I don't know where it's from. Did I miss something into a configuration?

qcampos added a parent revision: D63: Extract objstorage from swh.storage module and recreate its commit history..Jun 23 2016, 2:34 PM

qcampos added a task: T460: Extract the objstorage component from storage module to an independent module.

I don't know where it's from. Did I miss something into a configuration?

No, i don't think you missed anything.
It must be because we need to merge D63 first.
Otherwise, this module does not exist yet.

For information, this one is blocked by D63.
D63 is currently accepted, so it needs to be merged.

Then we can retrigger the tests to check everything is green.
Then if tests ok, we can merge.

Also, to be symmetric with D63, which includes the debian packaging, the packaging needs to be updated as well.

IIRC, the impacted files are:

requirements.txt (swh.objstorage)
debian/control (python-swh.objstorage)
setup.py (needs to remove some entries about swh.storage.objstorage...)

This revision now requires changes to proceed.Jun 24 2016, 10:10 AM

Extract http servers common code to swh.objstorage for dependencies
Remove objstorage scripts
Update debian packaging configuration files

ardumont added inline comments.Jun 27 2016, 1:31 PM

debian/control
24 ↗	(On Diff #223)	I think we do not need this. This is supposed to be taken care of by the setup.py script if i understood correctly @olasd the first time.