Page MenuHomeSoftware Heritage

Extract the object storage to its own package and do the required modifications on the imports
ClosedPublic

Authored by qcampos on Jun 23 2016, 2:30 PM.

Diff Detail

Repository
rDSTO Storage manager
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 241
Build 358: Software Heritage Python tests
Build 357: arc lint + arc unit

Event Timeline

qcampos retitled this revision from to Extract the object storage to its own package and do the required modifications on the imports.
qcampos updated this object.
qcampos edited the test plan for this revision. (Show Details)
qcampos added reviewers: olasd, zack.

The tests doesn't works (although make test in swh.storage works in local) because of :

======================================================================
ERROR: Failure: ImportError (No module named 'swh.objstorage')
----------------------------------------------------------------------

I don't know where it's from. Did I miss something into a configuration?

I don't know where it's from. Did I miss something into a configuration?

No, i don't think you missed anything.
It must be because we need to merge D63 first.
Otherwise, this module does not exist yet.

For information, this one is blocked by D63.
D63 is currently accepted, so it needs to be merged.

Then we can retrigger the tests to check everything is green.
Then if tests ok, we can merge.

ardumont added a reviewer: ardumont.

Also, to be symmetric with D63, which includes the debian packaging, the packaging needs to be updated as well.

IIRC, the impacted files are:

  • requirements.txt (swh.objstorage)
  • debian/control (python-swh.objstorage)
  • setup.py (needs to remove some entries about swh.storage.objstorage...)
This revision now requires changes to proceed.Jun 24 2016, 10:10 AM
qcampos edited edge metadata.
  • Extract http servers common code to swh.objstorage for dependencies
  • Remove objstorage scripts
  • Update debian packaging configuration files
debian/control
24 ↗(On Diff #223)

I think we do not need this.
This is supposed to be taken care of by the setup.py script if i understood correctly @olasd the first time.

zack edited edge metadata.
qcampos edited edge metadata.
qcampos marked an inline comment as done.

Remove an unneeded dependency into the debian/control file

  • Update debian packaging configuration files
ardumont edited edge metadata.
This revision is now accepted and ready to land.Jun 27 2016, 2:55 PM
This revision was automatically updated to reflect the committed changes.