Details

Reviewers

olasd
zack
ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T460: Extract the objstorage component from storage module to an independent module

Commits

rDOBJS339e6b1ecfb2: Extract objstorage from swh.storage module and recreate its commit history.

Summary

Extract swh.storage.objstorage to swh.objstorage and repare the outdated import to make the module work correctly.

Diff Detail

Repository

rDOBJS Object storage

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

qcampos updated this revision to Diff 206.Jun 23 2016, 12:44 PM

qcampos added a task: T460: Extract the objstorage component from storage module to an independent module.

qcampos retitled this revision from to Extract objstorage from swh.storage module and recreate its commit history..

qcampos updated this object.

qcampos added reviewers: olasd, zack.

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 23 2016, 12:44 PM

qcampos added a child revision: D64: Extract the object storage to its own package and do the required modifications on the imports.Jun 23 2016, 2:34 PM

Move the swh.storage.checker module into swh.objstorage.checker as this module works with the object storage.

Herald edited edge metadata. · View Herald TranscriptJun 23 2016, 2:43 PM

ardumont mentioned this in D64: Extract the object storage to its own package and do the required modifications on the imports.Jun 23 2016, 2:56 PM

ardumont added a subscriber: ardumont.Jun 23 2016, 3:09 PM

ardumont added inline comments.

swh/objstorage/tests/test_checker.py
14	swh.objstorage?

Move the swh.storage.checker module into swh.objstorage.checker as this module works with the object storage.
Import scripts from swh.storage
api: Move the http api-related code from storage to objstorage to keep the dependancy from the first to the second

Herald edited edge metadata. · View Herald TranscriptJun 23 2016, 3:35 PM

Thus far, this seems ok.
Waiting as per our discussion for the debian packaging part you already started ^^

Update debian packaging config

Herald edited edge metadata. · View Herald TranscriptJun 23 2016, 3:48 PM

ardumont added inline comments.Jun 23 2016, 3:59 PM

debian/control
21	Our convention seems to indicate the upper case on the first letter `Object Storage`

Update debian packaging config

The packaging is tested and works fine.

Herald edited edge metadata. · View Herald TranscriptJun 23 2016, 4:29 PM

Awesome

This revision is now accepted and ready to land.Jun 23 2016, 4:38 PM

Need to update the diff for changes in the commits and debian packaging

This revision now requires review to proceed.Jun 27 2016, 12:19 PM

qcampos marked an inline comment as done.Jun 27 2016, 12:20 PM

ardumont accepted this revision.Jun 27 2016, 12:54 PM

ardumont edited edge metadata.

This revision is now accepted and ready to land.Jun 27 2016, 12:54 PM

Closed by commit rDOBJS339e6b1ecfb2: Extract objstorage from swh.storage module and recreate its commit history. (authored by qcampos). · Explain WhyJun 27 2016, 1:15 PM

This revision was automatically updated to reflect the committed changes.

Extract objstorage from swh.storage module and recreate its commit history.
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 222

bin/swh-objstorage-add-dir

bin/swh-objstorage-fsck

debian/changelog

debian/control

debian/rules

requirements.txt

setup.py

swh/foo/bar.py

swh/objstorage/init.py

swh/objstorage/api/init.py

swh/objstorage/api/client.py

swh/objstorage/api/common.py

swh/objstorage/api/server.py

swh/objstorage/checker.py

swh/objstorage/exc.py

swh/objstorage/multiplexer/init.py

swh/objstorage/multiplexer/filter/init.py

swh/objstorage/multiplexer/filter/filter.py

swh/objstorage/multiplexer/filter/id_filter.py

swh/objstorage/multiplexer/filter/read_write_filter.py

swh/objstorage/multiplexer/multiplexer_objstorage.py

swh/objstorage/objstorage.py

swh/objstorage/objstorage_pathslicing.py

swh/objstorage/tests/objstorage_testing.py

swh/objstorage/tests/server_testing.py

swh/objstorage/tests/test_checker.py

swh/objstorage/tests/test_multiplexer_filter.py

swh/objstorage/tests/test_objstorage.py

swh/objstorage/tests/test_objstorage_api.py

swh/objstorage/tests/test_objstorage_multiplexer.py

swh/objstorage/tests/test_objstorage_pathslicing.py

Extract objstorage from swh.storage module and recreate its commit history.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 222

bin/swh-objstorage-add-dir

bin/swh-objstorage-fsck

debian/changelog

debian/control

debian/rules

requirements.txt

setup.py

swh/foo/bar.py

swh/objstorage/__init__.py

swh/objstorage/api/__init__.py

swh/objstorage/api/client.py

swh/objstorage/api/common.py

swh/objstorage/api/server.py

swh/objstorage/checker.py

swh/objstorage/exc.py

swh/objstorage/multiplexer/__init__.py

swh/objstorage/multiplexer/filter/__init__.py

swh/objstorage/multiplexer/filter/filter.py

swh/objstorage/multiplexer/filter/id_filter.py

swh/objstorage/multiplexer/filter/read_write_filter.py

swh/objstorage/multiplexer/multiplexer_objstorage.py

swh/objstorage/objstorage.py

swh/objstorage/objstorage_pathslicing.py

swh/objstorage/tests/objstorage_testing.py

swh/objstorage/tests/server_testing.py

swh/objstorage/tests/test_checker.py

swh/objstorage/tests/test_multiplexer_filter.py

swh/objstorage/tests/test_objstorage.py

swh/objstorage/tests/test_objstorage_api.py

swh/objstorage/tests/test_objstorage_multiplexer.py

swh/objstorage/tests/test_objstorage_pathslicing.py

Extract objstorage from swh.storage module and recreate its commit history.
ClosedPublic
Actions

Revision Contents
Changeset List

swh/objstorage/init.py

swh/objstorage/api/init.py

swh/objstorage/multiplexer/init.py

swh/objstorage/multiplexer/filter/init.py