Page MenuHomeSoftware Heritage
Differential D622

New tests for the Git loader.
ClosedPublic
Actions

Authored by vlorentz on Oct 30 2018, 3:47 PM.

Details

Reviewers
douardda
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T1219: add tests to git loader
Commits
rDLDGcaf409fb67a5: New tests for the Git loader.

Diff Detail

Repository
rDLDG Git loader
Branch
tests
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2008
Build 2432: tox-on-jenkinsJenkins
Build 2431: arc lint + arc unit

Event Timeline

vlorentz created this revision.Oct 30 2018, 3:47 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 30 2018, 3:47 PM
vlorentz added a parent revision: D621: Fix GitLoaderFromArchive..Oct 30 2018, 3:47 PM
vlorentz added a task: T1219: add tests to git loader.
swh-public-ci added a subscriber: swh-public-ci.Oct 30 2018, 3:48 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tox/13/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tox/13/console

Harbormaster failed remote builds in B2002: Diff 1911!Oct 30 2018, 3:48 PM
vlorentz added a parent revision: D623: Initialize BaseLoaderTest.repo_url for all tests..Oct 30 2018, 5:24 PM
vlorentz updated this revision to Diff 1917.Oct 30 2018, 6:09 PM
  • Rebase
swh-public-ci added a comment.Oct 30 2018, 6:12 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tox/16/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tox/16/console

Harbormaster failed remote builds in B2008: Diff 1917!Oct 30 2018, 6:12 PM
vlorentz updated this revision to Diff 1924.Oct 31 2018, 10:26 AM
  • Test the content of the snapshot and the revisions.
swh-public-ci added a comment.Oct 31 2018, 10:27 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tox/17/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tox/17/console

Harbormaster failed remote builds in B2014: Diff 1924!Oct 31 2018, 10:27 AM
vlorentz mentioned this in T1300: Release swh-loader-core v0.0.36.Oct 31 2018, 10:42 AM
vlorentz updated this revision to Diff 1926.Oct 31 2018, 12:04 PM
  • Bump required version of swh.loader.core.
  • Test the behavior when the origin is updated.
swh-public-ci added a comment.Oct 31 2018, 12:05 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tox/18/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tox/18/console

Harbormaster failed remote builds in B2016: Diff 1926!Oct 31 2018, 12:05 PM
vlorentz updated this revision to Diff 1928.Oct 31 2018, 12:19 PM
  • Fix version number.
swh-public-ci added a comment.Oct 31 2018, 12:19 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tox/19/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tox/19/console

Harbormaster failed remote builds in B2021: Diff 1928!Oct 31 2018, 12:19 PM
ardumont added subscribers: olasd, ardumont.Nov 1 2018, 10:01 AM
ardumont added inline comments.
swh/loader/git/tests/test_loader.py
187

Check with @olasd but i think that'd be the task T1258 (original discussion D409#8432).

douardda requested changes to this revision.Nov 5 2018, 1:26 PM
douardda added a subscriber: douardda.

Do you really need both the zip and tgz files in there?

This revision now requires changes to proceed.Nov 5 2018, 1:26 PM
vlorentz updated this revision to Diff 1931.Nov 5 2018, 2:53 PM
  • Fix test run where git is not configured.
  • Fix class names.
vlorentz added a comment.Nov 5 2018, 2:54 PM
In D622#12423, @douardda wrote:

Do you really need both the zip and tgz files in there?

I can, but it requires some extra code, see P329. What's your preference?

swh-public-ci added a comment.Nov 5 2018, 2:54 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tox/20/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tox/20/console

Harbormaster failed remote builds in B2034: Diff 1931!Nov 5 2018, 2:54 PM
douardda added a comment.Nov 5 2018, 3:10 PM
In D622#12430, @vlorentz wrote:
In D622#12423, @douardda wrote:

Do you really need both the zip and tgz files in there?

I can, but it requires some extra code, see P329. What's your preference?

without a doubt, I prefer 2 or 3 (ok maybe 10) lines of code than a 25k binary blob in the source code repo that duplicates another 10k binary blob

vlorentz updated this revision to Diff 1932.Nov 5 2018, 3:11 PM
  • Remove testrepo.zip.
swh-public-ci added a comment.Nov 5 2018, 3:12 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDG/job/tox/21/ for more details.

Harbormaster completed remote builds in B2035: Diff 1932.Nov 5 2018, 3:12 PM
vlorentz updated this revision to Diff 1933.Nov 5 2018, 3:12 PM
  • Remove testrepo.zip.
swh-public-ci added a comment.Nov 5 2018, 3:14 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDG/job/tox/22/ for more details.

Harbormaster completed remote builds in B2036: Diff 1933.Nov 5 2018, 3:14 PM
vlorentz retitled this revision from Start writing tests for the Git loader. to New tests for the Git loader..Nov 5 2018, 3:49 PM
vlorentz edited the summary of this revision. (Show Details)
ardumont accepted this revision.Nov 7 2018, 10:36 AM

Sounds like a good start.

douardda accepted this revision.Nov 9 2018, 11:38 AM
This revision is now accepted and ready to land.Nov 9 2018, 11:38 AM
Closed by commit rDLDGcaf409fb67a5: New tests for the Git loader. (authored by vlorentz). · Explain WhyNov 9 2018, 11:42 AM
This revision was automatically updated to reflect the committed changes.
vlorentz mentioned this in T1219: add tests to git loader.Nov 9 2018, 1:45 PM

Revision Contents
Changeset List

PathSize
swh/
loader/
git/
12 lines
tests/
resources/
101 lines

Diff 1917

View Options

swh/loader/git/loader.py

Loading...
View Options

swh/loader/git/tests/resources/testrepo.tgz

Loading...
View Options

swh/loader/git/tests/resources/testrepo.zip

Loading...
View Options

swh/loader/git/tests/test_loader.py

Loading...
About · Developer information · Legal