Page MenuHomeSoftware Heritage

New tests for the Git loader.
ClosedPublic

Authored by vlorentz on Oct 30 2018, 3:47 PM.

Diff Detail

Repository
rDLDG Git loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

  • Test the content of the snapshot and the revisions.
  • Bump required version of swh.loader.core.
  • Test the behavior when the origin is updated.
ardumont added inline comments.
swh/loader/git/tests/test_loader.py
187

Check with @olasd but i think that'd be the task T1258 (original discussion D409#8432).

douardda requested changes to this revision.Nov 5 2018, 1:26 PM
douardda added a subscriber: douardda.

Do you really need both the zip and tgz files in there?

This revision now requires changes to proceed.Nov 5 2018, 1:26 PM
  • Fix test run where git is not configured.
  • Fix class names.

Do you really need both the zip and tgz files in there?

I can, but it requires some extra code, see P329. What's your preference?

Do you really need both the zip and tgz files in there?

I can, but it requires some extra code, see P329. What's your preference?

without a doubt, I prefer 2 or 3 (ok maybe 10) lines of code than a 25k binary blob in the source code repo that duplicates another 10k binary blob

vlorentz retitled this revision from Start writing tests for the Git loader. to New tests for the Git loader..Nov 5 2018, 3:49 PM
vlorentz edited the summary of this revision. (Show Details)

Sounds like a good start.

This revision is now accepted and ready to land.Nov 9 2018, 11:38 AM
This revision was automatically updated to reflect the committed changes.