Page MenuHomeSoftware Heritage
Differential D519

tests: add a CeleryTestFixture that allows to specify a celery broker URL
AbandonedPublic
Actions

Authored by douardda on Oct 12 2018, 10:14 AM.

Details

Reviewers
olasd
vlorentz
ardumont
Group Reviewers
Reviewers
Summary

this especially aims at allowing to run tests that do actually use
non mocked celery broker using pifpaf.

  • add celery to test requirements
  • README: document how to get test data
  • add a tox.ini file

and mention tox in the README file. Also note that this tox file will
clone swh-storage-testdata if needed.

Test Plan

tox will not work as is (dependency to swh-core) so pifpaf --env-prefix PG run postgresql -- pifpaf --env-prefix AMQP run rabbitmq nosetests

Diff Detail

Repository
rDSCH Scheduling utilities
Branch
test-cfg-celery-broker-w-pifpaf
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1634
Build 1978: arc lint + arc unit

Event Timeline

douardda created this revision.Oct 12 2018, 10:14 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 12 2018, 10:14 AM
Harbormaster completed remote builds in B1634: Diff 1618.Oct 12 2018, 10:14 AM
douardda mentioned this in D518: Add tests using Celery..Oct 12 2018, 10:21 AM
zack removed 1 blocking reviewer(s): Reviewers.Oct 12 2018, 3:21 PM
olasd accepted this revision.Oct 12 2018, 4:10 PM
This revision is now accepted and ready to land.Oct 12 2018, 4:10 PM
ardumont accepted this revision.Oct 12 2018, 5:42 PM

And i forgot to finish that review ;)

README.md
21

everything

36

should

vlorentz added a comment.Oct 15 2018, 9:34 AM

Nice! Could you also add a result backend? I need this for D518

vlorentz requested changes to this revision.Oct 15 2018, 9:34 AM
This revision now requires changes to proceed.Oct 15 2018, 9:34 AM
vlorentz added a child revision: D518: Add tests using Celery..Oct 15 2018, 9:35 AM
douardda added a comment.Oct 15 2018, 9:52 AM
In D519#10350, @vlorentz wrote:

Nice! Could you also add a result backend? I need this for D518

let me see that

vlorentz removed a child revision: D518: Add tests using Celery..Oct 15 2018, 2:34 PM
douardda abandoned this revision.Oct 17 2018, 12:20 PM

This diff has already landed as of 15e895e5df077208ed628172a9709ce1fdd0a8c4 but indeed, a better solution is needed as proposed in latest version of D531

Revision Contents
Changeset List

PathSize
1 line
60 lines
1 line
swh/
scheduler/
tests/
37 lines
3 lines
15 lines

Diff 1618

View Options

.gitignore

Loading...
View Options

README.md

Loading...
View Options

requirements-test.txt

Loading...
View Options

swh/scheduler/tests/celery_testing.py

Loading...
View Options

swh/scheduler/tests/test_task.py

Loading...
View Options

tox.ini

Loading...
About · Developer information · Legal