migrate_extrinsic_metadata: Write metadata on directories instead of revisions.
ClosedPublic
Actions

Authored by vlorentz on Oct 23 2020, 5:26 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T2668: Package loaders should write extrinsic metadata on directories instead of revisions/releases

Commits

rDSTO6e3e35096f61: migrate_extrinsic_metadata: Write metadata on directories instead of revisions.

Summary

To match the new behavior of package loaders, in D4346 and D4347

Part of T2668

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 16714
Build 25775: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 25774: arc lint + arc unit

Event Timeline

vlorentz created this revision.Oct 23 2020, 5:26 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 23 2020, 5:26 PM

vlorentz added a task: T2668: Package loaders should write extrinsic metadata on directories instead of revisions/releases.Oct 23 2020, 5:26 PM

Build is green

Patch application report for D4349 (id=15384)

Rebasing onto 474ee72b07...

Current branch diff-target is up to date.

Changes applied before test

commit 87a1020a35f36568384449b67e5bafc751739e8b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Oct 23 17:25:35 2020 +0200

    migrate_extrinsic_metadata: Write metadata on directories instead of revisions.
    
    To match the new behavior of package loaders.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1022/ for more details.

Harbormaster completed remote builds in B16611: Diff 15384.Oct 23 2020, 5:31 PM

olasd mentioned this in D4367: Replace RawExtrinsicMetadata `id` attribute with `target`..Oct 27 2020, 3:51 PM

To rebase this patch on D4367:

wget https://forge.softwareheritage.org/file/data/xr4aumcikib3o6dx7z4b/PHID-FILE-q67ktvrk3ev4zmtf3xzu/D4349.diff
sed -i 's/id\(=.*swhid\)/target\1/i' D4349.diff
patch -Np1 < D4349.diff

(or apply the same sed command to swh/storage/tests/migrate_extrinsic_metadata/, plausibly)

rebase (thx for the script)

Build is green

Patch application report for D4349 (id=15488)

Rebasing onto 97d0b05597...

Current branch diff-target is up to date.

Changes applied before test

commit 6e3e35096f619464b6b14ff3ddbb928e354865ba
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Oct 29 11:14:48 2020 +0100

    migrate_extrinsic_metadata: Write metadata on directories instead of revisions.
    
    To match the new behavior of package loaders.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1028/ for more details.

Harbormaster completed remote builds in B16714: Diff 15488.Oct 29 2020, 11:19 AM