Page MenuHomeSoftware Heritage

migrate_extrinsic_metadata: Write metadata on directories instead of revisions.
ClosedPublic

Authored by vlorentz on Oct 23 2020, 5:26 PM.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D4349 (id=15384)

Rebasing onto 474ee72b07...

Current branch diff-target is up to date.
Changes applied before test
commit 87a1020a35f36568384449b67e5bafc751739e8b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Oct 23 17:25:35 2020 +0200

    migrate_extrinsic_metadata: Write metadata on directories instead of revisions.
    
    To match the new behavior of package loaders.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1022/ for more details.

To rebase this patch on D4367:

wget https://forge.softwareheritage.org/file/data/xr4aumcikib3o6dx7z4b/PHID-FILE-q67ktvrk3ev4zmtf3xzu/D4349.diff
sed -i 's/id\(=.*swhid\)/target\1/i' D4349.diff
patch -Np1 < D4349.diff

(or apply the same sed command to swh/storage/tests/migrate_extrinsic_metadata/, plausibly)

rebase (thx for the script)

Build is green

Patch application report for D4349 (id=15488)

Rebasing onto 97d0b05597...

Current branch diff-target is up to date.
Changes applied before test
commit 6e3e35096f619464b6b14ff3ddbb928e354865ba
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Oct 29 11:14:48 2020 +0100

    migrate_extrinsic_metadata: Write metadata on directories instead of revisions.
    
    To match the new behavior of package loaders.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1028/ for more details.

ardumont added a subscriber: ardumont.

looks good to me.

a question inline but nothing blocking.

swh/storage/tests/migrate_extrinsic_metadata/test_cran.py
34

f-string?

121

is object_id and target the same thing now, i don't remember?
If so which one shall we use now?

This revision is now accepted and ready to land.Oct 29 2020, 12:51 PM