Replace RawExtrinsicMetadata `id` attribute with `target`.
ClosedPublic
Actions

Authored by olasd on Oct 27 2020, 3:51 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDSTO9645aef7abab: Replace RawExtrinsicMetadata `id` attribute with `target`.

Summary

The old attribute was deprecated in swh.model 0.7.2

Test Plan

pytest -W error:RawExtrinsicMetadata:DeprecationWarning passes,
when using swh.journal with D4365 applied, and swh.model with D4366 applied.

Conflicts with D4349 pretty hard.

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Oct 27 2020, 3:51 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 27 2020, 3:51 PM

Build is green

Patch application report for D4367 (id=15436)

Rebasing onto 581968322a...

Current branch diff-target is up to date.

Changes applied before test

commit 9645aef7abab83121d98fc7fe4f62f4859b5d0c9
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Oct 27 13:52:22 2020 +0100

    Replace RawExtrinsicMetadata `id` attribute with `target`.
    
    The old attribute was deprecated in swh.model 0.7.2

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1024/ for more details.

anlambert accepted this revision.Oct 27 2020, 3:56 PM

This revision is now accepted and ready to land.Oct 27 2020, 3:56 PM

Harbormaster completed remote builds in B16664: Diff 15436.Oct 27 2020, 3:56 PM

olasd mentioned this in D4349: migrate_extrinsic_metadata: Write metadata on directories instead of revisions..Oct 27 2020, 4:33 PM

Closed by commit rDSTO9645aef7abab: Replace RawExtrinsicMetadata `id` attribute with `target`. (authored by olasd). · Explain WhyOct 27 2020, 4:39 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSTO9645aef7abab: Replace RawExtrinsicMetadata `id` attribute with `target`..