Page MenuHomeSoftware Heritage

Move sharable fixtures out of conftest into a dedicated pytest plugin
ClosedPublic

Authored by olasd on Jul 6 2020, 2:57 PM.

Details

Summary

This avoids having to run from swh.scheduler.tests.conftest import * in other
modules, e.g. swh.lister, to import and use the swh_scheduler pytest fixture.

Test Plan

tox tests unchanged

Diff Detail

Repository
rDSCH Scheduling utilities
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13379
Build 20454: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 20453: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D3430 (id=12148)

Rebasing onto 5b373ceb36...

Current branch diff-target is up to date.
Changes applied before test
commit 9d963c0be54460beb90bbab18d07b1f0c0efc27a
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Jul 6 14:51:41 2020 +0200

    Move sharable fixtures out of conftest into a dedicated pytest plugin
    
    This avoids having to run `from swh.scheduler.tests.conftest import *` in other
    modules, e.g. swh.lister, to import and use the swh_scheduler pytest fixture.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/38/ for more details.

ardumont added a subscriber: ardumont.

\m/

Thanks ;)

This revision is now accepted and ready to land.Jul 6 2020, 4:11 PM

Build is green

Patch application report for D3430 (id=12159)

Rebasing onto 5b373ceb36...

Current branch diff-target is up to date.
Changes applied before test
commit b2cbb9ba856c5c3ad736e3170be58ad081c96d69
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Jul 6 14:51:41 2020 +0200

    Move shareable fixtures out of conftest into a dedicated pytest plugin
    
    This avoids having to run `from swh.scheduler.tests.conftest import *` in other
    modules, e.g. swh.lister, to import and use the swh_scheduler pytest fixture.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/39/ for more details.