tests: Use dedicated storage and scheduler fixtures
ClosedPublic
Actions

Authored by ardumont on Jul 7 2020, 6:05 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2484: Move sharable fixtures out of conftest into a dedicated pytest plugin

Commits

rDLDBASE488b515a1c87: tests: Use dedicated storage and scheduler fixtures

Summary

Related to D3452
Related to T2484

Test Plan

tox

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 7 2020, 6:05 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 7 2020, 6:05 PM

Build has FAILED

Patch application report for D3453 (id=12228)

Rebasing onto 3e48d63e88...

Current branch diff-target is up to date.

Changes applied before test

commit 225cd77d80e281fd9dbeef7c0976e99803a28f3d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Jul 7 18:03:11 2020 +0200

    tests: Use dedicated storage fixture
    
    Related to D3452
    Related to T2484

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/113/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/113/console

Harbormaster failed remote builds in B13448: Diff 12228!Jul 7 2020, 6:06 PM

ardumont mentioned this in D3452: Move sharable fixtures out of conftest into a dedicated pytest plugin.Jul 7 2020, 6:08 PM

vlorentz added a subscriber: vlorentz.Jul 8 2020, 10:01 AM

vlorentz added inline comments.

conftest.py
12	you should also be able to remove this line, thanks to D3430

ardumont added inline comments.Jul 8 2020, 2:29 PM

conftest.py
12	yeah right, i wanted to do that in a future commit

ardumont added inline comments.Jul 8 2020, 2:30 PM

conftest.py
12	But yeah, i'll tag the storage v0.10.1 and add the necessary requirements on scheduler as well ;)

ardumont retitled this revision from tests: Use dedicated storage fixture to tests: Use dedicated storage and scheduler fixtures.Jul 8 2020, 2:34 PM

ardumont edited the test plan for this revision. (Show Details)

Adapt according to remark

Build is green

Patch application report for D3453 (id=12251)

Rebasing onto 3e48d63e88...

Current branch diff-target is up to date.

Changes applied before test

commit 488b515a1c876a4b56fc7dadcc2ef4c8f3854c43
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Jul 7 18:03:11 2020 +0200

    tests: Use dedicated storage and scheduler fixtures
    
    Related to D3452
    Related to D3430
    Related to T2484

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/114/ for more details.

Harbormaster completed remote builds in B13470: Diff 12251.Jul 8 2020, 2:48 PM

ardumont added inline comments.Jul 8 2020, 2:51 PM