Page MenuHomeSoftware Heritage
Differential D6809

option to skip bdist_wheel and only upload a source package
ClosedPublic
Actions

Authored by olasd on Dec 9 2021, 11:22 AM.

Details

Reviewers
dachary
ardumont
Group Reviewers
System administrators
Maniphest Tasks
T3634: Create swh-perfecthash module
Commits
rCJSWH0a790895c890: option to skip bdist_wheel and only upload a source package
Summary

uploading architecture dependent wheels would require using manylinux
for them to be uploaded to pypi.

https://www.python.org/dev/peps/pep-0513/#rationale

Diff Detail

Repository
rCJSWH Jenkins jobs
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dachary created this revision.Dec 9 2021, 11:22 AM
Herald added a reviewer: System administrators. · View Herald TranscriptDec 9 2021, 11:22 AM
dachary requested review of this revision.Dec 9 2021, 11:22 AM
Harbormaster completed remote builds in B25531: Diff 24677.Dec 9 2021, 11:22 AM
dachary added a task: T3634: Create swh-perfecthash module.Dec 9 2021, 11:36 AM
olasd commandeered this revision.Dec 9 2021, 4:21 PM
olasd added a reviewer: dachary.
olasd updated this revision to Diff 24692.Dec 9 2021, 4:22 PM

Make the parameter INCLUDE_BDIST

Harbormaster completed remote builds in B25545: Diff 24692.Dec 9 2021, 4:22 PM
ardumont accepted this revision.Dec 10 2021, 10:03 AM
ardumont added a subscriber: ardumont.

Awesome.

You make it appear so easy to modify this kind of stuff ;)

This revision is now accepted and ready to land.Dec 10 2021, 10:03 AM
dachary accepted this revision.Dec 10 2021, 10:07 AM

This is all news to me but it makes intuitive sense. Plus it was tested manually and I can testify it worked. So I review positively (yeah, I make a big deal out of this because this is my first review ;-) )

Closed by commit rCJSWH0a790895c890: option to skip bdist_wheel and only upload a source package (authored by olasd). · Explain WhyDec 13 2021, 10:22 AM
This revision was automatically updated to reflect the committed changes.
olasd added a commit: rCJSWH0a790895c890: option to skip bdist_wheel and only upload a source package.

Revision Contents
Changeset List

PathSize
jobs/
1 line
templates/
8 lines
6 lines

Diff 24747

View Options

jobs/swh-packages.yaml

Loading...
View Options

jobs/templates/swh-pypi.groovy.j2

Loading...
View Options

jobs/templates/swh-pypi.yaml

Loading...
About · Developer information · Legal