Page MenuHomeSoftware Heritage
Differential D6545

base-buster: add valgrind and googletest for swh.perfecthash
ClosedPublic
Actions

Authored by dachary on Oct 25 2021, 10:56 AM.

Details

Reviewers
ardumont
Group Reviewers
System administrators
Reviewers
Maniphest Tasks
T3634: Create swh-perfecthash module
Commits
rCDFJ4af01e989e88: base-buster: add valgrind and googletest for swh.perfecthash
Summary

Related to T3634

Diff Detail

Repository
rCDFJ Dockerfiles for Jenkins
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dachary created this revision.Oct 25 2021, 10:56 AM
Harbormaster completed remote builds in B24674: Diff 23790.Oct 25 2021, 10:56 AM
dachary requested review of this revision.Oct 25 2021, 10:56 AM
dachary updated this revision to Diff 23791.

fix typo in the commit comment

Harbormaster completed remote builds in B24675: Diff 23791.Oct 25 2021, 10:57 AM
dachary retitled this revision from base-buster: add valrind for swh.perfecthash to base-buster: add valgrind for swh.perfecthash.Oct 25 2021, 10:58 AM
ardumont accepted this revision.Oct 25 2021, 11:00 AM
ardumont added reviewers: System administrators, Reviewers.
This revision is now accepted and ready to land.Oct 25 2021, 11:02 AM
dachary updated this revision to Diff 23793.Oct 25 2021, 11:18 AM

googletest is also needed

Harbormaster completed remote builds in B24677: Diff 23793.Oct 25 2021, 11:18 AM
dachary retitled this revision from base-buster: add valgrind for swh.perfecthash to base-buster: add valgrind and googletest for swh.perfecthash.Oct 25 2021, 11:18 AM
ardumont accepted this revision.Oct 25 2021, 12:10 PM
dachary mentioned this in T3634: Create swh-perfecthash module.Oct 25 2021, 11:26 PM
olasd added a subscriber: olasd.Nov 18 2021, 1:28 PM

@dachary please rebase and push this

dachary updated this revision to Diff 24190.Nov 18 2021, 2:04 PM

rebase

Harbormaster completed remote builds in B25071: Diff 24190.Nov 18 2021, 2:04 PM
dachary added a comment.Dec 8 2021, 6:00 PM

I thought it was pushed already, I must have overlooked it somehow. Doing it now.

Closed by commit rCDFJ4af01e989e88: base-buster: add valgrind and googletest for swh.perfecthash (authored by dachary). · Explain WhyDec 8 2021, 6:13 PM
This revision was automatically updated to reflect the committed changes.
dachary added a commit: rCDFJ4af01e989e88: base-buster: add valgrind and googletest for swh.perfecthash.

Revision Contents
Changeset List

PathSize
base-buster/
2 lines

Diff 24661

View Options

base-buster/Dockerfile

Loading...
About · Developer information · Legal