Page MenuHomeSoftware Heritage
Create Task
Maniphest T2729

lookup_content_license and lookup_content_language fail since swh.indexer.storage v0.3
Closed, MigratedEdits Locked
Actions

Description

It looks like I missed this in D4190; that code doesn't seem to be covered (or the idx-storage is possibly mocked in tests and they need to be updated; I didn't check)

SWH-WEBAPP-1CV

SWH-WEBAPP-1CY

Revisions and Commits

rDWAPPS Web applications
D4355rDWAPPS3ffeb396fa10 lookup_content_license: Fix crash with swh.storage.indexer v0.3.0.
D4353rDWAPPSd1643344e5e5 Remove requests to 'idx_storage.content_language_get'.

Related Objects

Event Timeline

vlorentz triaged this task as Unbreak Now! priority.Oct 24 2020, 1:14 PM
vlorentz created this task.
anlambert added a subscriber: anlambert.Oct 26 2020, 11:33 AM

Actually, there is a test for it but it requires fossology tools installed in order for the indexer to run and produce license data. Maybe we should produce dummy license data when the fossology tools are missing to ensure code is always covered ?

vlorentz added a revision: D4353: Remove requests to 'idx_storage.content_language_get'..Oct 26 2020, 2:40 PM
vlorentz added a commit: rDWAPPSd1643344e5e5: Remove requests to 'idx_storage.content_language_get'..Oct 26 2020, 4:27 PM
vlorentz claimed this task.Oct 26 2020, 4:40 PM
vlorentz mentioned this in D4355: lookup_content_license: Fix crash with swh.storage.indexer v0.3.0..Oct 26 2020, 4:40 PM
vlorentz added a revision: D4355: lookup_content_license: Fix crash with swh.storage.indexer v0.3.0..Oct 26 2020, 4:49 PM
vlorentz added a commit: rDWAPPS3ffeb396fa10: lookup_content_license: Fix crash with swh.storage.indexer v0.3.0..Oct 27 2020, 2:59 PM
vlorentz closed this task as Resolved.Oct 27 2020, 2:59 PM
ardumont mentioned this in rDMOD8e121bbc0d0c: model.identifiers: Fix one space too many in error message.Nov 12 2020, 1:03 PM
gitlab-migration changed the task status from Resolved to Migrated.Jan 8 2023, 4:31 PM
gitlab-migration claimed this task.
gitlab-migration added a subscriber: gitlab-migration.

This task has been migrated to GitLab.

About · Developer information · Legal