Differential D4355

lookup_content_license: Fix crash with swh.storage.indexer v0.3.0.
ClosedPublic
Actions

Authored by vlorentz on Oct 26 2020, 4:40 PM.

Details

Reviewers

anlambert

Maniphest Tasks

T2729: lookup_content_license and lookup_content_language fail since swh.indexer.storage v0.3

Commits

rDWAPPS3ffeb396fa10: lookup_content_license: Fix crash with swh.storage.indexer v0.3.0.

Summary

Because it returns attr objects instead of dicts now.

This wasn't caught before, because test_api_content_license only runs if
'nomossa' is installed, and it usually isn't.

Second half of the fix for T2729.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Oct 26 2020, 4:40 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 26 2020, 4:40 PM

vlorentz edited reviewers, added: anlambert; removed: Reviewers.Oct 26 2020, 4:41 PM

Build is green

Patch application report for D4355 (id=15401)

Rebasing onto d1643344e5...

Current branch diff-target is up to date.

Changes applied before test

commit 11061be40e4d5b900be0bc8be646319ded3c15b6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Oct 26 16:40:22 2020 +0100

    lookup_content_license: Fix crash with swh.storage.indexer v0.3.0.
    
    Because it returns attr objects instead of dicts now.
    
    This wasn't caught before, because test_api_content_license only runs if
    'nomossa' is installed, and it usually isn't.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/436/ for more details.

Harbormaster completed remote builds in B16630: Diff 15401.Oct 26 2020, 4:48 PM

vlorentz added a task: T2729: lookup_content_license and lookup_content_language fail since swh.indexer.storage v0.3.Oct 26 2020, 4:49 PM

undo changes to the API return format

Build is green

Patch application report for D4355 (id=15415)

Rebasing onto d1643344e5...

Current branch diff-target is up to date.

Changes applied before test

commit 3ffeb396fa10c9cc6b45161cbf520fbf9833c90d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Oct 26 16:40:22 2020 +0100

    lookup_content_license: Fix crash with swh.storage.indexer v0.3.0.
    
    Because it returns attr objects instead of dicts now.
    
    This wasn't caught before, because test_api_content_license only runs if
    'nomossa' is installed, and it usually isn't.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/438/ for more details.

Harbormaster completed remote builds in B16642: Diff 15415.Oct 27 2020, 11:05 AM

anlambert accepted this revision.Oct 27 2020, 1:18 PM

This revision is now accepted and ready to land.Oct 27 2020, 1:18 PM

Closed by commit rDWAPPS3ffeb396fa10: lookup_content_license: Fix crash with swh.storage.indexer v0.3.0. (authored by vlorentz). · Explain WhyOct 27 2020, 2:59 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDWAPPS3ffeb396fa10: lookup_content_license: Fix crash with swh.storage.indexer v0.3.0..