Differential D4353

Remove requests to 'idx_storage.content_language_get'.
ClosedPublic
Actions

Authored by vlorentz on Oct 26 2020, 2:40 PM.

Details

Reviewers

anlambert

Maniphest Tasks

T2729: lookup_content_license and lookup_content_language fail since swh.indexer.storage v0.3

Commits

rDWAPPSd1643344e5e5: Remove requests to 'idx_storage.content_language_get'.

Summary

It's broken since swh.indexer.storage v0.3.0, as it now returns attr objects
instead of dicts:
https://sentry.softwareheritage.org/share/issue/892044828a09460cab28283afc926cde/

And it wasn't very useful anyway (it barely contains results for any content),
so I'm removing this code entirely.

Half-resolves T2729

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Oct 26 2020, 2:40 PM

Build is green

Patch application report for D4353 (id=15397)

Rebasing onto 5c26fb27ab...

Current branch diff-target is up to date.

Changes applied before test

commit d1643344e5e5db698f8d335e5491a7b5991c88c1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Oct 26 14:39:59 2020 +0100

    Remove requests to 'idx_storage.content_language_get'.
    
    It's broken since swh.indexer.storage v0.3.0, as it now returns attr objects
    instead of dicts:
    https://sentry.softwareheritage.org/share/issue/892044828a09460cab28283afc926cde/
    
    And it wasn't very useful anyway (it barely contains results for any content),
    so I'm removing this code entirely.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/435/ for more details.

Harbormaster completed remote builds in B16626: Diff 15397.Oct 26 2020, 2:47 PM

anlambert accepted this revision.Oct 26 2020, 3:15 PM

This revision is now accepted and ready to land.Oct 26 2020, 3:15 PM

Closed by commit rDWAPPSd1643344e5e5: Remove requests to 'idx_storage.content_language_get'. (authored by vlorentz). · Explain WhyOct 26 2020, 4:27 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDWAPPSd1643344e5e5: Remove requests to 'idx_storage.content_language_get'..