Page MenuHomeSoftware Heritage
Create Task
Maniphest T1304

Web UI: fail to render some repositories with 500 error "'NoneType' object is not subscriptable"
Closed, MigratedEdits Locked
Actions

Description

The following repositories (I've other examples if needed) fail to be rendered by the Web UI with error message 'NoneType' object is not subscriptable:

I haven't checked what we have actually archived for them, but they've been visited recently and the corresponding GitHub repos seem to be in good shape.

If something is wrong with archival we need a better error message. If they've been archived properly we need to render what we have archived.

Revisions and Commits

rDWAPPS Web applications
rDWAPPS915144b1c4e6 browse.utils.process_snapshot_branches: Skip null revisions

Related Objects

Event Timeline

zack renamed this task from Web UI: fail to render some repositories with error "'NoneType' object is not subscriptable" to Web UI: fail to render some repositories with 500 error "'NoneType' object is not subscriptable".Nov 2 2018, 9:12 PM
zack triaged this task as High priority.
zack created this task.
anlambert added a subscriber: anlambert.EditedNov 5 2018, 10:51 AM

This seems due to releases pointing to missing revisions in the archive, see for instance https://archive.softwareheritage.org/api/1/release/21d03ad29cfa315d8b7e5d7577964fbc21797f74/

anlambert claimed this task.Nov 5 2018, 11:13 AM
zack added a subscriber: olasd.Nov 5 2018, 12:41 PM
In T1304#24431, @anlambert wrote:

This seems due to releases pointing to missing revisions in the archive, see for instance http://localhost:5004/api/1/release/21d03ad29cfa315d8b7e5d7577964fbc21797f74/

Interesting.

We should be able to render something anyway, and error out only when the user tries to visit the missing object.

This raises an additional question though. This is a freshly ingested repository, it's kinda weird that a release object is missing. Unless the archived repo was corrupted, maybe? @olasd can you have a look at this part? TIA

anlambert closed this task as Resolved by committing rDWAPPS915144b1c4e6: browse.utils.process_snapshot_branches: Skip null revisions.Nov 5 2018, 5:33 PM
anlambert added a commit: rDWAPPS915144b1c4e6: browse.utils.process_snapshot_branches: Skip null revisions.
zack added a comment.Nov 5 2018, 5:54 PM

thanks! can you ping me when this fix (T1304) is deployed?

anlambert added a comment.Nov 6 2018, 1:40 PM

@zack, this is now deployed.

anlambert mentioned this in T1309: Web UI: fails rendering archived repository with 500 error "directory".Nov 6 2018, 10:14 PM
gitlab-migration changed the task status from Resolved to Migrated.Jan 8 2023, 4:25 PM
gitlab-migration claimed this task.
gitlab-migration added a subscriber: gitlab-migration.

This task has been migrated to GitLab.

About · Developer information · Legal