Page MenuHomeSoftware Heritage

loader.git.reader: Remove unused code
ClosedPublic

Authored by ardumont on Dec 17 2018, 10:26 AM.

Details

Summary

The loader git reader was a tryout to make the archiver go faster. As
it's unused and not tested, better make it go away.

Unrelated to this diff, just a heads-up. Next step is to increase the
coverage of the tasks module.

Related T1219

Test Plan

tox

Diff Detail

Repository
rDLDG Git loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Dec 17 2018, 10:26 AM
ardumont updated this revision to Diff 2633.Dec 17 2018, 10:27 AM

Rework commit message

It's used in snippets/tasks/send-1000-stars-repo.py

douardda accepted this revision.Dec 17 2018, 10:28 AM
This revision is now accepted and ready to land.Dec 17 2018, 10:28 AM

and in snippets/olasd/consistency/fix_revisions.py

ardumont edited the summary of this revision. (Show Details)Dec 17 2018, 10:32 AM

snippets/tasks/send-1000-stars-repo.py

That's not so bad (i don't see it in my repository though).

snippets/olasd/consistency/fix_revisions.py

That's more problematic but then again, that's not production code...
I'm pondering whether reverting this or moving the reader code in snippet...

snippets/tasks/send-1000-stars-repo.py

That's not so bad (i don't see it in my repository though).

Cleaning up my local repository, opening my eyes, i see it ;)

This revision was automatically updated to reflect the committed changes.