Page MenuHomeSoftware Heritage

Improve logging configuration in celery's setup_log_handler function and logging of the listener
ClosedPublic

Authored by douardda on Jan 8 2019, 10:48 AM.

Details

Summary

logging config

  • allow to pass the loglevel as a string,
  • kill useless tmp variables,
  • add a filter to prevent amqp's heartbeat_tick debug messages.

listener

  • do use a dedicated logger instead of the root logger,
  • add a couple of logging statements (in perform_action methods),
  • replace the --verbose cli option by --log-level

Diff Detail

Repository
rDSCH Scheduling utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jan 8 2019, 10:48 AM
ardumont accepted this revision.Jan 8 2019, 10:57 AM
ardumont added a subscriber: ardumont.
ardumont added inline comments.
swh/scheduler/celery_backend/listener.py
68 ↗(On Diff #2818)

'Try performing' or 'Try to perform'

This revision is now accepted and ready to land.Jan 8 2019, 10:57 AM
vlorentz accepted this revision.Jan 8 2019, 10:57 AM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/scheduler/celery_backend/listener.py
186 ↗(On Diff #2818)

Why not the default format?

This revision was automatically updated to reflect the committed changes.