Page MenuHomeSoftware Heritage
Differential D888

Kill the CustomCelery class
ClosedPublic
Actions

Authored by douardda on Jan 8 2019, 10:53 AM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDSCH292e5dcd0597: Kill the CustomCelery class
Summary

use functions instead of methods.

This is required to be able to use celery pytest fixtures so one can
really test celery tasks (especially when a task spawns sub tasks).

one (get_queue_lenth) of the 3 methods has been added as (monkeypatched)
method on the Celery class for the sake of bw compat, but this should really
be removed as well as soon as possible (seems only used in swh-archiver).

Diff Detail

Repository
rDSCH Scheduling utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jan 8 2019, 10:53 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 8 2019, 10:53 AM
Harbormaster failed remote builds in B3271: Diff 2821!Jan 8 2019, 10:53 AM
swh-public-ci added a subscriber: swh-public-ci.Jan 8 2019, 10:53 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/60/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/60/console

douardda added a parent revision: D887: Improve cli and add 3 commands.Jan 8 2019, 10:56 AM
ardumont accepted this revision.Jan 8 2019, 11:56 AM
This revision is now accepted and ready to land.Jan 8 2019, 11:56 AM
douardda updated this revision to Diff 2852.Jan 9 2019, 4:54 PM

Rename newly added DEFAULT_CONFIG var in CELERY_DEFAULT_CONFIG

since DEFAULT_CONFIG already exists in this file...

Harbormaster failed remote builds in B3310: Diff 2852!Jan 9 2019, 4:55 PM
swh-public-ci added a comment.Jan 9 2019, 4:55 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/61/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/61/console

douardda updated this revision to Diff 2855.Jan 9 2019, 5:06 PM

rebased

Harbormaster failed remote builds in B3315: Diff 2855!Jan 9 2019, 5:07 PM
swh-public-ci added a comment.Jan 9 2019, 5:07 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/64/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/64/console

douardda mentioned this in D902: Add loader workers services.Jan 9 2019, 5:29 PM
douardda updated this revision to Diff 2884.Jan 10 2019, 3:49 PM

rebased

Harbormaster failed remote builds in B3358: Diff 2884!Jan 10 2019, 3:51 PM
swh-public-ci added a comment.Jan 10 2019, 3:51 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/71/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/71/console

Closed by commit rDSCH292e5dcd0597: Kill the CustomCelery class (authored by douardda). · Explain WhyJan 10 2019, 3:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
scheduler/
celery_backend/
122 lines
tests/
6 lines

Diff 2892

View Options

swh/scheduler/celery_backend/config.py

Loading...
View Options

swh/scheduler/tests/scheduler_testing.py

Loading...
About · Developer information · Legal