Page MenuHomeSoftware Heritage

Kill the CustomCelery class
ClosedPublic

Authored by douardda on Tue, Jan 8, 10:53 AM.

Details

Summary

use functions instead of methods.

This is required to be able to use celery pytest fixtures so one can
really test celery tasks (especially when a task spawns sub tasks).

one (get_queue_lenth) of the 3 methods has been added as (monkeypatched)
method on the Celery class for the sake of bw compat, but this should really
be removed as well as soon as possible (seems only used in swh-archiver).

Diff Detail

Repository
rDSCH Scheduling utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Tue, Jan 8, 10:53 AM
ardumont accepted this revision.Tue, Jan 8, 11:56 AM
This revision is now accepted and ready to land.Tue, Jan 8, 11:56 AM
douardda updated this revision to Diff 2852.Wed, Jan 9, 4:54 PM

Rename newly added DEFAULT_CONFIG var in CELERY_DEFAULT_CONFIG

since DEFAULT_CONFIG already exists in this file...

douardda updated this revision to Diff 2855.Wed, Jan 9, 5:06 PM

rebased

This revision was automatically updated to reflect the committed changes.