Page MenuHomeSoftware Heritage

loader.git.reader: Remove unused code
ClosedPublic

Authored by ardumont on Dec 17 2018, 10:26 AM.

Details

Summary

The loader git reader was a tryout to make the archiver go faster. As
it's unused and not tested, better make it go away.

Unrelated to this diff, just a heads-up. Next step is to increase the
coverage of the tasks module.

Related T1219

Test Plan

tox

Diff Detail

Repository
rDLDG Git loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3061
Build 3911: tox-on-jenkinsJenkins
Build 3910: arc lint + arc unit

Event Timeline

It's used in snippets/tasks/send-1000-stars-repo.py

This revision is now accepted and ready to land.Dec 17 2018, 10:28 AM

and in snippets/olasd/consistency/fix_revisions.py

snippets/tasks/send-1000-stars-repo.py

That's not so bad (i don't see it in my repository though).

snippets/olasd/consistency/fix_revisions.py

That's more problematic but then again, that's not production code...
I'm pondering whether reverting this or moving the reader code in snippet...

snippets/tasks/send-1000-stars-repo.py

That's not so bad (i don't see it in my repository though).

Cleaning up my local repository, opening my eyes, i see it ;)