Paths

Table of Contentst

Differential D831

loader.git.reader: Remove unused code
ClosedPublic
Actions

Authored by ardumont on Dec 17 2018, 10:26 AM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Commits

rDLDG65f740c8a13c: loader.git.reader: Remove unused code

Summary

The loader git reader was a tryout to make the archiver go faster. As
it's unused and not tested, better make it go away.

Unrelated to this diff, just a heads-up. Next step is to increase the
coverage of the tasks module.

Related T1219

Test Plan

tox

Diff Detail

Repository

rDLDG Git loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Dec 17 2018, 10:26 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 17 2018, 10:26 AM

Rework commit message

It's used in snippets/tasks/send-1000-stars-repo.py

Build is green
See https://jenkins.softwareheritage.org/job/DLDG/job/tox/64/ for more details.

Harbormaster completed remote builds in B3061: Diff 2631.Dec 17 2018, 10:27 AM

douardda accepted this revision.Dec 17 2018, 10:28 AM

This revision is now accepted and ready to land.Dec 17 2018, 10:28 AM

and in snippets/olasd/consistency/fix_revisions.py

Build is green
See https://jenkins.softwareheritage.org/job/DLDG/job/tox/65/ for more details.

Harbormaster completed remote builds in B3063: Diff 2633.Dec 17 2018, 10:29 AM

ardumont edited the summary of this revision. (Show Details)Dec 17 2018, 10:32 AM

snippets/tasks/send-1000-stars-repo.py

That's not so bad (i don't see it in my repository though).

snippets/olasd/consistency/fix_revisions.py

That's more problematic but then again, that's not production code...
I'm pondering whether reverting this or moving the reader code in snippet...

snippets/tasks/send-1000-stars-repo.py

That's not so bad (i don't see it in my repository though).

Cleaning up my local repository, opening my eyes, i see it ;)

ardumont mentioned this in rDSNIPdaddc79e7b43: Remove tryout tests.Dec 17 2018, 11:00 AM

Closed by commit rDLDG65f740c8a13c: loader.git.reader: Remove unused code (authored by ardumont). · Explain WhyDec 17 2018, 11:54 AM

This revision was automatically updated to reflect the committed changes.

ardumont mentioned this in rDSNIP360c49faa9bd: Move reader alongside needed consistency/fix_revision module.

Revision Contents
Changeset List

Path

Size

swh/

loader/

git/

reader.py

tasks.py

15 lines

Diff 2642

View Options

swh/loader/git/reader.py