Page MenuHomeSoftware Heritage

docker: update the list of created topics
ClosedPublic

Authored by douardda on Aug 8 2022, 12:17 PM.

Diff Detail

Repository
rDENV Development environment
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd added a subscriber: olasd.

Shouldn't we add privileged topics too?

This revision is now accepted and ready to land.Aug 8 2022, 12:27 PM
vsellier added inline comments.
docker/docker-compose.yml
23

TIL the possibility to specify the cleanup policy here.

Shouldn't this be specified for all the topics?

anlambert added a subscriber: anlambert.

kafka service healthcheck needs to be updated before landing this.

docker/docker-compose.yml
44–45

Since you have added new kafka topics, the healthcheck condition should be updated to ensure all topics got created before starting services depending on those,
the code below seems to do the trick:

healthcheck:
    test: "[ `JMX_PORT= kafka-topics.sh --list --zookeeper zookeeper:2181 | wc -l`
        -ge `echo $$KAFKA_CREATE_TOPICS | tr ',' '\n' | wc -l` ]"
This revision now requires changes to proceed.Aug 8 2022, 2:48 PM

apply/fix comments

  • make all topics compact
  • add privileged topics
  • update healthcheck test
docker/docker-compose.yml
23

indeed, I though I did but I may have goofed a rebase or smthg

44–45

good catch thanks

This revision is now accepted and ready to land.Aug 9 2022, 11:09 AM