Page MenuHomeSoftware Heritage
Differential D769

snapshot_add: Check the origin visit exists.
ClosedPublic
Actions

Authored by vlorentz on Dec 4 2018, 2:00 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDSTOCbda7cf156749: snapshot_add: Check the origin visit exists.
rDSTOCb6b004b3be15: snapshot_add: Check the origin visit exists.
R65:b6b004b3be15: snapshot_add: Check the origin visit exists.
R65:bda7cf156749: snapshot_add: Check the origin visit exists.
rDSTObda7cf156749: snapshot_add: Check the origin visit exists.
rDSTOb6b004b3be15: snapshot_add: Check the origin visit exists.
Summary

Instead of failing silently (PG storage) or raising an un-documented
exception (in-mem storage).

Diff Detail

Repository
rDSTO Storage manager
Branch
snapshot_add-check-ids
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2807
Build 3528: tox-on-jenkinsJenkins
Build 3527: arc lint + arc unit

Event Timeline

vlorentz created this revision.Dec 4 2018, 2:00 PM
swh-public-ci added a subscriber: swh-public-ci.Dec 4 2018, 2:05 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/134/ for more details.

Harbormaster completed remote builds in B2807: Diff 2411.Dec 4 2018, 2:05 PM
vlorentz mentioned this in D767: storage.in_memory: Use integer ids for origin and visit instead of tuples.Dec 4 2018, 2:12 PM
anlambert accepted this revision.Dec 4 2018, 2:26 PM
anlambert added inline comments.
swh/storage/db.py
585

s/ids/id/

This revision is now accepted and ready to land.Dec 4 2018, 2:26 PM
vlorentz marked an inline comment as done.Dec 4 2018, 3:55 PM
vlorentz added inline comments.
swh/storage/db.py
585

Nope: origin id + visit id

Closed by commit rDSTOb6b004b3be15: snapshot_add: Check the origin visit exists. (authored by vlorentz). · Explain WhyDec 4 2018, 3:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
storage/
10 lines
5 lines
6 lines
tests/
7 lines

Diff 2411

View Options

swh/storage/db.py

Loading...
View Options

swh/storage/in_memory.py

Loading...
View Options

swh/storage/storage.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal