Page MenuHomeSoftware Heritage

svn: Retry info command when network error occurs
ClosedPublic

Authored by anlambert on Apr 21 2022, 12:03 PM.

Details

Summary

This makes the loader more resilient to temporary network failures.

Fixes SWH-LOADER-SVN-6Q.

Depends on D7619

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D7620 (id=27596)

Could not rebase; Attempt merge onto 056dfe7804...

Updating 056dfe7..dba8ecb
Fast-forward
 swh/loader/svn/loader.py               | 41 +++++++++++++++++++---------------
 swh/loader/svn/svn.py                  | 10 +++++++--
 swh/loader/svn/tests/conftest.py       | 11 +++++++++
 swh/loader/svn/tests/test_externals.py | 10 +--------
 swh/loader/svn/tests/test_loader.py    | 36 +++++++++++++++++++++++++++++
 swh/loader/svn/tests/test_svn_retry.py | 41 ++++++++++++++++++++++++++++++++++
 6 files changed, 120 insertions(+), 29 deletions(-)
Changes applied before test
commit dba8ecb9b67309d2aa7a2482cda58b33050c9985
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Apr 21 11:59:50 2022 +0200

    svn: Retry info command when network error occurs
    
    This makes the loader more resilient to temporary network failures.

commit 8e7fffa7823a253b6e19abb75b6376b319a7d4e5
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Apr 21 11:19:50 2022 +0200

    SvnLoaderFromRemoteDump: Fix not_found visit status for non first visit
    
    When a subversion origin no longer exists since its last visit,
    SvnLoaderFromRemoteDump was not setting visit status to "not_found" but
    to "failed. So ensure to set correct visit status when encountering
    such cases.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/320/ for more details.

This revision is now accepted and ready to land.Apr 21 2022, 2:30 PM

Build is green

Patch application report for D7620 (id=27605)

Could not rebase; Attempt merge onto 5b9065fd64...

Updating 5b9065f..3cf5cbd
Fast-forward
 swh/loader/svn/loader.py               | 41 +++++++++++++++++++---------------
 swh/loader/svn/svn.py                  | 10 +++++++--
 swh/loader/svn/tests/conftest.py       | 11 +++++++++
 swh/loader/svn/tests/test_externals.py | 10 +--------
 swh/loader/svn/tests/test_loader.py    | 36 +++++++++++++++++++++++++++++
 swh/loader/svn/tests/test_svn_retry.py | 41 ++++++++++++++++++++++++++++++++++
 6 files changed, 120 insertions(+), 29 deletions(-)
Changes applied before test
commit 3cf5cbdfb625b11b67181840df455eae66dd44db
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Apr 21 11:59:50 2022 +0200

    svn: Retry info command when network error occurs
    
    This makes the loader more resilient to temporary network failures.

commit e198d4e514468a402cf8b8ee24c809b6824229be
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Apr 21 11:19:50 2022 +0200

    SvnLoaderFromRemoteDump: Fix not_found visit status for non first visit
    
    When a subversion origin no longer exists since its last visit,
    SvnLoaderFromRemoteDump was not setting visit status to "not_found" but
    to "failed. So ensure to set correct visit status when encountering
    such cases.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/322/ for more details.