Differential D7619

SvnLoaderFromRemoteDump: Fix not_found visit status for non first visit
ClosedPublic
Actions

Authored by anlambert on Apr 21 2022, 11:33 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDSVNe198d4e51446: SvnLoaderFromRemoteDump: Fix not_found visit status for non first visit

Summary

When a subversion origin no longer exists since its last visit,
SvnLoaderFromRemoteDump was not setting visit status to "not_found" but
to "failed. So ensure to set correct visit status when encountering
such cases.

Fixes SWH-LOADER-SVN-7A.

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 21 2022, 11:33 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 21 2022, 11:33 AM

Build is green

Patch application report for D7619 (id=27593)

Rebasing onto 821a51307a...

Current branch diff-target is up to date.

Changes applied before test

commit 5b81f38eb75fe8e4f3439bc2f233731859d636e6
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Apr 21 11:19:50 2022 +0200

    SvnLoaderFromRemoteDump: Fix not_found visit status for non first visit
    
    When a subversion origin no longer exists since its last visit,
    SvnLoaderFromRemoteDump was not setting visit status to "not_found" but
    to "failed. So ensure to set correct visit status when encountering
    such cases.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/318/ for more details.

Harbormaster completed remote builds in B28620: Diff 27593.Apr 21 2022, 11:36 AM

anlambert requested review of this revision.Apr 21 2022, 11:36 AM

Rebase

Build is green

Patch application report for D7619 (id=27595)

Rebasing onto 056dfe7804...

Current branch diff-target is up to date.

Changes applied before test

commit 8e7fffa7823a253b6e19abb75b6376b319a7d4e5
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Apr 21 11:19:50 2022 +0200

    SvnLoaderFromRemoteDump: Fix not_found visit status for non first visit
    
    When a subversion origin no longer exists since its last visit,
    SvnLoaderFromRemoteDump was not setting visit status to "not_found" but
    to "failed. So ensure to set correct visit status when encountering
    such cases.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/319/ for more details.

Harbormaster completed remote builds in B28622: Diff 27595.Apr 21 2022, 11:39 AM

anlambert added a child revision: D7620: svn: Retry info command when network error occurs.Apr 21 2022, 12:03 PM

ardumont accepted this revision.Apr 21 2022, 2:28 PM

This revision is now accepted and ready to land.Apr 21 2022, 2:28 PM

Rebase

Build is green

Patch application report for D7619 (id=27604)

Rebasing onto 5b9065fd64...

Current branch diff-target is up to date.

Changes applied before test

commit e198d4e514468a402cf8b8ee24c809b6824229be
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Apr 21 11:19:50 2022 +0200

    SvnLoaderFromRemoteDump: Fix not_found visit status for non first visit
    
    When a subversion origin no longer exists since its last visit,
    SvnLoaderFromRemoteDump was not setting visit status to "not_found" but
    to "failed. So ensure to set correct visit status when encountering
    such cases.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/321/ for more details.

Harbormaster completed remote builds in B28659: Diff 27604.Apr 21 2022, 2:43 PM

Closed by commit rDLDSVNe198d4e51446: SvnLoaderFromRemoteDump: Fix not_found visit status for non first visit (authored by anlambert). · Explain WhyApr 21 2022, 2:51 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDSVNe198d4e51446: SvnLoaderFromRemoteDump: Fix not_found visit status for non first visit.