Page MenuHomeSoftware Heritage
Differential D740

Remove mocks from test_metadata.py.
ClosedPublic
Actions

Authored by vlorentz on Nov 29 2018, 5:10 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T1307: Remove mock storages used in tests.
Commits
rDCIDXf2da0055d977: Update version requirements.
rDCIDXa85946a6f449: Remove mocks from test_metadata.py.
Summary

Depends on D739
Depends on D737

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Nov 29 2018, 5:10 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 29 2018, 5:10 PM
swh-public-ci added a subscriber: swh-public-ci.Nov 29 2018, 5:13 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/79/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/79/console

Harbormaster failed remote builds in B2696: Diff 2319!Nov 29 2018, 5:14 PM
ardumont mentioned this in D742: indexer: Simplify the init step for the last tests.Nov 29 2018, 5:50 PM
vlorentz updated this revision to Diff 2323.Nov 29 2018, 6:04 PM
  • Remove hack
vlorentz updated this revision to Diff 2325.Nov 29 2018, 6:07 PM
  • fix push
Harbormaster completed remote builds in B2700: Diff 2323.Nov 29 2018, 6:07 PM
swh-public-ci added a comment.Nov 29 2018, 6:07 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/82/ for more details.

swh-public-ci added a comment.Nov 29 2018, 6:12 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/84/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/84/console

Harbormaster failed remote builds in B2702: Diff 2325!Nov 29 2018, 6:12 PM
ardumont accepted this revision.Nov 30 2018, 11:06 AM
ardumont added a subscriber: ardumont.

ok, sounds about consistent with 740.

This revision is now accepted and ready to land.Nov 30 2018, 11:06 AM
swh-public-ci added a comment.Nov 30 2018, 11:12 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/92/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/92/console

vlorentz updated this revision to Diff 2346.Nov 30 2018, 11:15 AM
  • Rebase
vlorentz added a parent revision: D737: Add 'recursive' argument to the in-mem storage..Nov 30 2018, 11:17 AM
In D740#15518, @swh-public-ci wrote:

Build has FAILED

Because it depends on D737 being released.

swh-public-ci added a comment.Nov 30 2018, 11:18 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/93/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/93/console

Harbormaster failed remote builds in B2725: Diff 2346!Nov 30 2018, 11:18 AM
swh-public-ci added a comment.Nov 30 2018, 11:42 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/94/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/94/console

ardumont edited the summary of this revision. (Show Details)Nov 30 2018, 12:08 PM

D737 merged.
swh-storage 0.0.113 tagged and uploaded to pypi.
Now this needs a bumps in requirements.txt (and debian/control).

vlorentz updated this revision to Diff 2356.Nov 30 2018, 12:25 PM
  • Update version requirements.
swh-public-ci added a comment.Nov 30 2018, 12:29 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/95/ for more details.

Harbormaster completed remote builds in B2736: Diff 2356.Nov 30 2018, 12:29 PM
ardumont accepted this revision.Nov 30 2018, 12:33 PM
Closed by commit rDCIDXa85946a6f449: Remove mocks from test_metadata.py. (authored by vlorentz). · Explain WhyNov 30 2018, 12:34 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a task: T1307: Remove mock storages used in tests..Dec 5 2018, 1:44 PM

Revision Contents
Changeset List

PathSize
swh/
indexer/
tests/
106 lines

Diff 2357

View Options

swh/indexer/tests/test_metadata.py

Loading...
About · Developer information · Legal