Page MenuHomeSoftware Heritage
Differential D739

Extract data literals from mocks
ClosedPublic
Actions

Authored by vlorentz on Nov 29 2018, 5:08 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDCIDXdbcb0a6e1ca0: Extract data literals from mocks
rDCIDXf0ccfa7deab6: Increase required version of swh.storage.
rDCIDX757041694cdf: Increase required version of swh.objstorage.
rDCIDX91324b92c20d: Extract data literals from mocks
Summary

provide functions to fill actual storages with them.

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Nov 29 2018, 5:08 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 29 2018, 5:08 PM
vlorentz added a child revision: D740: Remove mocks from test_metadata.py..Nov 29 2018, 5:10 PM
swh-public-ci added a subscriber: swh-public-ci.Nov 29 2018, 5:11 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/78/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/78/console

Harbormaster failed remote builds in B2695: Diff 2318!Nov 29 2018, 5:11 PM
ardumont added a subscriber: ardumont.Nov 29 2018, 5:22 PM

Build has FAILED

because that needs a new version from swh-objstorage (which needs tagging as well).

Other than that, that feels good.

ardumont mentioned this in D742: indexer: Simplify the init step for the last tests.Nov 29 2018, 5:42 PM
ardumont added a comment.Nov 30 2018, 10:14 AM
Build has FAILED

because that needs a new version from swh-objstorage (which needs tagging as well).

The new objstorage 0.0.28 is published now.
Please, update the requirements.txt (and debian/control also for now) in the diff so that we can trigger back the build.

vlorentz updated this revision to Diff 2334.Nov 30 2018, 10:17 AM
  • Increase required version of swh.objstorage.
swh-public-ci added a comment.Nov 30 2018, 10:20 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/85/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/85/console

Harbormaster failed remote builds in B2711: Diff 2334!Nov 30 2018, 10:20 AM
vlorentz updated this revision to Diff 2337.Nov 30 2018, 10:39 AM
  • Increase required version of swh.storage.
swh-public-ci added a comment.Nov 30 2018, 10:40 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/87/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/87/console

Harbormaster failed remote builds in B2714: Diff 2337!Nov 30 2018, 10:40 AM
swh-public-ci added a comment.Nov 30 2018, 10:46 AM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/88/ for more details.

ardumont added a comment.EditedNov 30 2018, 10:48 AM

Build is green

Yes, i restarted it because the last one did not see yet the new swh.storage 0.0.112 tag.

swh-public-ci added a comment.Nov 30 2018, 10:59 AM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/90/ for more details.

ardumont accepted this revision.Nov 30 2018, 10:59 AM

That will need a rebase

This revision is now accepted and ready to land.Nov 30 2018, 10:59 AM
Harbormaster completed remote builds in B2714: Diff 2337.Nov 30 2018, 10:59 AM
vlorentz updated this revision to Diff 2341.Nov 30 2018, 11:10 AM
  • Rebase
Closed by commit rDCIDX757041694cdf: Increase required version of swh.objstorage. (authored by vlorentz). · Explain WhyNov 30 2018, 11:11 AM
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B2719: Diff 2341!Nov 30 2018, 11:11 AM
swh-public-ci added a comment.Nov 30 2018, 11:11 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/91/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/91/console

Revision Contents
Changeset List

PathSize
2 lines

Diff 2343

View Options

requirements-swh.txt

Loading...
About · Developer information · Legal