Differential D742

indexer: Simplify the init step for the last tests
ClosedPublic
Actions

Authored by ardumont on Nov 29 2018, 5:42 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDCIDX5bbdf7ffbe5f: tests: Simplify init step
rDCIDXfbb2bb1c8dc8: fossology_license: Fix docstring

Summary

tests: Simplify init step

This is probably either in conflict with D740 or need to be rebased
after it.

fossology_license: Fix docstring

Test Plan

tox

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Nov 29 2018, 5:42 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/80/ for more details.

Harbormaster completed remote builds in B2698: Diff 2321.Nov 29 2018, 5:45 PM

vlorentz requested changes to this revision.Nov 29 2018, 5:45 PM

vlorentz added inline comments.

swh/indexer/tests/test_origin_metadata.py
159–164 ↗	(On Diff #2321)	^^
swh/indexer/tests/test_utils.py
362–368 ↗	(On Diff #2321)	No, that should raise an error.

This revision now requires changes to proceed.Nov 29 2018, 5:45 PM

ardumont edited the summary of this revision. (Show Details)Nov 29 2018, 5:50 PM

Remove spurious noise

ardumont added inline comments.Nov 29 2018, 5:57 PM

swh/indexer/tests/test_origin_metadata.py
51 ↗	(On Diff #2321)	but no! that was a tryout.
swh/indexer/tests/test_utils.py
362–368 ↗	(On Diff #2321)	In that case, the tests simply won't work. the tool_id does not exist. That's a test initialization issue. the tool_id somehow is a one from the memory storage. I don't get from where that comes from since it's supposed to be mock storage all around. All this class should go away as that's not tractable in the current state. So i'm for this ugly hack in the mean time (which will get trashed pretty soon).

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/81/ for more details.

Harbormaster completed remote builds in B2699: Diff 2322.Nov 29 2018, 5:58 PM

Remove hack

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/83/ for more details.

Harbormaster completed remote builds in B2701: Diff 2324.Nov 29 2018, 6:10 PM

vlorentz added inline comments.Nov 30 2018, 10:21 AM

swh/indexer/tests/test_origin_metadata.py
51 ↗	(On Diff #2321)	?

ardumont marked an inline comment as done.Nov 30 2018, 10:24 AM

ardumont added inline comments.

swh/indexer/tests/test_origin_metadata.py
51 ↗	(On Diff #2321)	revision_metadata_indexer = RevisionMetadataTestIndexer() which has come back and needs to go. I'll update the diff again.

vlorentz added inline comments.Nov 30 2018, 10:25 AM

swh/indexer/tests/test_origin_metadata.py
51 ↗	(On Diff #2321)	sorry :/

Get back the diff to its feet

The diff got changed by error and i no longer see the right state
there.

ardumont marked an inline comment as done.Nov 30 2018, 10:51 AM

ardumont added inline comments.

swh/indexer/tests/test_origin_metadata.py
51 ↗	(On Diff #2321)	life happens, don't worry ;)

vlorentz accepted this revision.Nov 30 2018, 10:51 AM

This revision is now accepted and ready to land.Nov 30 2018, 10:51 AM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/89/ for more details.

Harbormaster completed remote builds in B2716: Diff 2339.Nov 30 2018, 10:53 AM

Closed by commit rDCIDXfbb2bb1c8dc8: fossology_license: Fix docstring (authored by ardumont). · Explain WhyNov 30 2018, 10:56 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

indexer/

fossology_license.py

3 lines

Diff 2340

swh/indexer/fossology_license.py

Loading...