No need to filter out revisions as well, this is already handled elsewhere.
Along with D7028, this resolves T3884.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- Restricted Maniphest Task
- Commits
- rDLDBASE4718713b9ae0: Filter out extids targeting non-existing releases
Diff Detail
Diff Detail
- Repository
- rDLDBASE Generic VCS/Package Loader
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 26335 Build 41177: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 41176: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D7029 (id=25479)
Rebasing onto 78b2e9f7f4...
Current branch diff-target is up to date.
Changes applied before test
commit dddd7d49262d6f553ecf8c898a3415fd1bdf71c3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Jan 24 18:03:57 2022 +0100
Filter out extids targeting non-existing releases
No need to filter out revisions as well, this is already handled elsewhere.
Along with D7028, this resolves T3884.See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/687/ for more details.
Comment Actions
I wonder if that'd be worth a warning. May end up being a bit noisy though.
Or, in other words: are there any usecases where inserting an extid pointing to an object we don't have in the archive makes sense?
Comment Actions
Sentry recorded only two occurences so far, so it shouldn't be too noisy.
Or, in other words: are there any usecases where inserting an extid pointing to an object we don't have in the archive makes sense?
I don't see any, especially not in package loaders
Comment Actions
Build is green
Patch application report for D7029 (id=25504)
Rebasing onto 78b2e9f7f4...
Current branch diff-target is up to date.
Changes applied before test
commit 4718713b9ae0c7fedefd82d0d5944c4871943065
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Jan 24 18:03:57 2022 +0100
Filter out extids targeting non-existing releases
No need to filter out revisions as well, this is already handled elsewhere.
Along with D7028, this resolves T3884.See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/688/ for more details.