Differential D7028

Do not load extids on failed visits
ClosedPublic
Actions

Authored by vlorentz on Jan 24 2022, 5:33 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

Restricted Maniphest Task

Commits

rDLDBASE78b2e9f7f4f0: Do not load extids on failed visits

Summary

They may point to non-existing objects, which is useless.

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jan 24 2022, 5:33 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 24 2022, 5:33 PM

Build is green

Patch application report for D7028 (id=25473)

Rebasing onto 29b9029a40...

Current branch diff-target is up to date.

Changes applied before test

commit 78b2e9f7f4f0cbae4846c7fc67d49cd8af551a8d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Jan 24 17:33:16 2022 +0100

    Do not load extids on failed visits
    
    They may point to non-existing objects, which is useless.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/686/ for more details.

Harbormaster completed remote builds in B26308: Diff 25473.Jan 24 2022, 5:35 PM

vlorentz requested review of this revision.Jan 24 2022, 5:35 PM

ardumont accepted this revision.Jan 24 2022, 5:37 PM

This revision is now accepted and ready to land.Jan 24 2022, 5:37 PM

looks sensible to me

Closed by commit rDLDBASE78b2e9f7f4f0: Do not load extids on failed visits (authored by vlorentz). · Explain WhyJan 24 2022, 6:01 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLDBASE78b2e9f7f4f0: Do not load extids on failed visits.

vlorentz mentioned this in D7029: Filter out extids targeting non-existing releases.Jan 24 2022, 6:04 PM

vlorentz added a task: Restricted Maniphest Task.Jan 24 2022, 6:04 PM

vlorentz mentioned this in rDLDBASE4718713b9ae0: Filter out extids targeting non-existing releases.Jan 26 2022, 11:30 AM