Depends on D682.
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T1307: Remove mock storages used in tests.
- Commits
- rDLDGf86bc3d19964: Use the in-mem storage instead of mocks to test the git loader.
rDLDGc725b7c5febc: Apply method renaming.
rDLDGf71c8b0c202f: Don't read config files from the tests.
rDLDGe6cf09256856: Actually override the storage config.
rDLDG7a2444d8f70f: Override the loader's config to avoid initializing a remote storage.
rDLDG33c90822855e: Use the in-mem storage instead of mocks.
Diff Detail
- Repository
- rDLDG Git loader
- Branch
- inmem-storage
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 2838 Build 3579: tox-on-jenkins Jenkins Build 3578: arc lint + arc unit
Event Timeline
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tox/30/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tox/30/console
swh/loader/git/tests/test_loader.py | ||
---|---|---|
181 | Note: that's an unrelated change. |
swh/loader/git/tests/test_loader.py | ||
---|---|---|
117 | I do not like doing this... The GitLoader and the BulkUpdater allows to pass the config dict instead (do not like it either [1] but it's better than mutating the loader instance). That would also avoid the side effect of loading the configuration file from disk... [1] because it's been opened solely for the tests... | |
181 | CONTENT1 is probably badly named then since i see that it's not one content but many ;) |
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tox/31/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tox/31/console
swh/loader/git/tests/test_loader.py | ||
---|---|---|
117 | Agreed. As we talked earlier today, this will need a change to swh.storage.get_storage (D689). | |
181 | It's the contents, at "version 1" of the DB (version 0 = before the loader runs, version 1 = after it runs for the first time, version 2 = after it runs for the second time). |
swh/loader/git/tests/test_loader.py | ||
---|---|---|
181 | CONTENTS_v{0,1,2} etc... would have been more appropriate... |
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tox/33/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tox/33/console
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tox/34/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tox/34/console
swh/loader/git/tests/test_loader.py | ||
---|---|---|
105 | Do you need to? So, that could create divergence on dev box if they have some configuration files in the right places ({/etc/softwareheritage/,~/.swh,~/.config/swh}/loader/git-{loader,updater}.yml)) |
swh/loader/git/tests/test_loader.py | ||
---|---|---|
105 | I need a way to obtain content_packet_size and its many friends. |
swh/loader/git/tests/test_loader.py | ||
---|---|---|
105 | In other modules, we duplicate (for now) that information in the TestLoader (TestGitLoader for example). Side-effects/configuration duplication trade-offs. |
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tox/35/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tox/35/console
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tox/36/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tox/36/console
swh/loader/git/tests/test_loader.py | ||
---|---|---|
103 | I'm the source of disagreement here. If you take a look at the discussion just below this remark, you'll see the detail ;) |
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tox/37/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tox/37/console
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tox/57/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tox/57/console
Build is green
See https://jenkins.softwareheritage.org/job/DLDG/job/tox/58/ for more details.