Page MenuHomeSoftware Heritage
Differential D680

Make it official that content_missing accepts missing keys.
ClosedPublic
Actions

Authored by vlorentz on Nov 20 2018, 3:52 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDSTOC37d70d653f4a: Make it official that content_missing accepts missing keys.
R65:37d70d653f4a: Make it official that content_missing accepts missing keys.
rDSTO37d70d653f4a: Make it official that content_missing accepts missing keys.
Summary

The PG Storage provides that feature, and the Git loader uses it.
This commit documents that feature, adds it to the Mem Storage,
and changes test_content_missing to test that behavior.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Nov 20 2018, 3:52 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 20 2018, 3:52 PM
vlorentz updated this revision to Diff 2147.Nov 20 2018, 4:03 PM
  • min_size=0
vlorentz updated this revision to Diff 2148.Nov 20 2018, 4:05 PM
  • Undo unrelated change to the PgStorage.
swh-public-ci added a subscriber: swh-public-ci.Nov 20 2018, 4:20 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/91/ for more details.

Harbormaster completed remote builds in B2462: Diff 2142.Nov 20 2018, 4:20 PM
swh-public-ci added a comment.Nov 20 2018, 4:35 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/94/ for more details.

Harbormaster completed remote builds in B2467: Diff 2147.Nov 20 2018, 4:35 PM
swh-public-ci added a comment.Nov 20 2018, 4:46 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/96/ for more details.

Harbormaster completed remote builds in B2468: Diff 2148.Nov 20 2018, 4:46 PM
ardumont accepted this revision.Nov 20 2018, 5:36 PM
This revision is now accepted and ready to land.Nov 20 2018, 5:36 PM
vlorentz added a child revision: D682: Use the in-mem storage instead of mocks in BaseLoaderTest..Nov 21 2018, 3:28 PM
vlorentz mentioned this in D682: Use the in-mem storage instead of mocks in BaseLoaderTest..
Closed by commit rDSTO37d70d653f4a: Make it official that content_missing accepts missing keys. (authored by vlorentz). · Explain WhyNov 21 2018, 3:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
storage/
24 lines
11 lines
tests/
14 lines

Diff 2157

View Options

swh/storage/in_memory.py

Loading...
View Options

swh/storage/storage.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal