Page MenuHomeSoftware Heritage

Fix typing which fails the build
AbandonedPublic

Authored by ardumont on Dec 9 2021, 10:25 AM.

Details

Reviewers
None
Group Reviewers
Reviewers
Summary
Test Plan

tox (happy?)

Diff Detail

Repository
rDLDBZR BZR loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25521
Build 39902: arc lint + arc unit

Event Timeline

Rebase to check build triggering in jenkins actually happens

Note: we added the required Language-python flag to the repository configuration

Rebase to make the build ok now

Note: Added the staging repository configuration to the repository

Build has FAILED

Patch application report for D6806 (id=24668)

Rebasing onto 75bffa424f...

Current branch diff-target is up to date.
Changes applied before test
commit 198dd353701f5bc618d34cc4f473620e4e32ad6a
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Thu Dec 9 10:24:04 2021 +0100

    Fix typing which fails the build
    
    [1] https://jenkins.softwareheritage.org/view/swh-draft/job/DLDBZR/job/tests/73/console

Link to build: https://jenkins.softwareheritage.org/job/DLDBZR/job/tests-on-diff/2/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBZR/job/tests-on-diff/2/console

Link to build: https://jenkins.softwareheritage.org/job/DLDBZR/job/tests-on-diff/2/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBZR/job/tests-on-diff/2/console

That's another error related to docs now.
But I can't fix it.

As @Alphare is currently working on the repository, i'll let this be.

At least, @olasd and me fixed the repository's configuration so now new diff for that repository will build out of the box!
So progress!!!

Cheers,

@Alphare heads up, it'd be great you could push a few commits to make the build green here (even if incomplete).

I'm currently fighting the overall jenkins' redness (but this was was red already prior to the actual firefighting i'm doing).
So i'm letting that diff go and won't touch this repository in that quest.

Please have a look at T3812 at some point to align the loader-bzr repository with what's described there.
Thanks in advance.

Cheers,

@Alphare heads up, it'd be great you could push a few commits to make the build green here (even if incomplete).

I've been pushing to a draft, should I just publish the draft and then say it's still one in the comments?

Please have a look at T3812 at some point to align the loader-bzr repository with what's described there.
Thanks in advance.

Sure thing. Looking at it quickly it looks like a simple commit for that particular file should do the trick?

Cheers,

I've been pushing to a draft, should I just publish the draft and then say it's still one in the comments?

sgtm

Sure thing. Looking at it quickly it looks like a simple commit for that particular file should do the trick?

yes indeed.

You can just do the same as this diff D6853 (including the mypy pinning that will prevent such surprise later ;)

superseded by the future work from @Alphare so closing this.