Page MenuHomeSoftware Heritage
Create Task
Maniphest T3812

Fix builds broken by mypy 0.920
Closed, MigratedEdits Locked
Actions

Description

A new release of mypy 0.920 is currently breaking our python builds.

I've filed an issue [1] about this as i don't clearly see what's the problem.

Another workaround would be to pin 0.910 in all tox.ini.

[1] https://github.com/python/mypy/issues/11769

Revisions and Commits

rDSCH Scheduling utilities
D6856rDSCH559f3451c6c3 Pin mypy and drop type annotations which makes mypy unhappy
rDPROV Provenance database
D6854rDPROVbef0ab385dfa Drop unnecessary type annotation to fix mypy 0.920 issue
rDWAPPS Web applications
D6855rDWAPPS7ae38cf0568c Pin mypy and drop type annotations which makes mypy unhappy
rDSTO Storage manager
D6859rDSTOf09a54d4f523 Pin mypy and drop type annotations which makes mypy unhappy
rDCORE Foundations and core functionalities
D6857rDCORE4ff374f2f7a7 Pin mypy and drop type annotations which makes mypy unhappy
rDLDCVS CVS Loader
D6853rDLDCVScbde981229dc Pin mypy and drop type annotations which makes mypy unhappy

Related Objects

Mentioned In
rTSBX113e0a5a9625: Pin mypy and drop type annotations which makes mypy unhappy
rDMFCDae5dbe16ccff: Pin mypy and drop type annotations which makes mypy unhappy
rDGRPH4d36535f9e58: Pin mypy and drop type annotations which makes mypy unhappy
rDCNTdb50e8217802: Pin mypy and drop type annotations which makes mypy unhappy
rDLSec7838123b0f: Pin mypy and drop type annotations which makes mypy unhappy
rDCIDXfcfdc21f099a: Pin mypy and drop type annotations which makes mypy unhappy
rDICPc4f025e849c1: Pin mypy and drop type annotations which makes mypy unhappy
rDFUSEe4e75768acf5: Pin mypy and drop type annotations which makes mypy unhappy
rDDOCa3aeb8ace15f: Pin mypy and drop type annotations which makes mypy unhappy
rDDEP9807be11d043: Pin mypy and drop type annotations which makes mypy unhappy
rDDATASET8d9fcb8edf6f: Pin mypy and drop type annotations which makes mypy unhappy
rDAUTH0cd18057732b: Pin mypy and drop type annotations which makes mypy unhappy
rDMODabb089d4cf41: Pin mypy and drop type annotations which makes mypy unhappy
rDWCLIb93e751f0d16: Pin mypy and drop type annotations which makes mypy unhappy
rDVAUab311983a8dc: Pin mypy and drop type annotations which makes mypy unhappy
rDSEA50fedafcf645: Pin mypy and drop type annotations which makes mypy unhappy
rDTSCN1b97932feb41: Pin mypy and drop type annotations which makes mypy unhappy
rDTPL8e232a888066: Pin mypy and drop type annotations which makes mypy unhappy
rDOPH7fd6dbac76e7: Pin mypy and drop type annotations which makes mypy unhappy
rDOBJSRPLfa5dfe038234: Pin mypy and drop type annotations which makes mypy unhappy
rDOBJS4238095a6c9a: Pin mypy and drop type annotations which makes mypy unhappy
rDLDSVN196c9d596bb2: Pin mypy and drop type annotations which makes mypy unhappy
rDLDHG2180cbbbbe60: Pin mypy and drop type annotations which makes mypy unhappy
rDLDG715fbe212d90: Pin mypy and drop type annotations which makes mypy unhappy
rDLDBASE32b2b7bba8b7: Pin mypy and drop type annotations which makes mypy unhappy
rDJNL4e5e00988a4e: Pin mypy and drop type annotations which makes mypy unhappy\n\nRelated to T3812
D6806: Fix typing which fails the build
D6850: Adapt coverage tooltip for debian based distributions

Event Timeline

ardumont triaged this task as Normal priority.Dec 16 2021, 12:40 PM
ardumont created this task.
ardumont updated the task description. (Show Details)
ardumont mentioned this in D6850: Adapt coverage tooltip for debian based distributions.Dec 16 2021, 12:43 PM
ardumont added a revision: D6853: Pin mypy and drop type annotations which makes mypy unhappy.Dec 16 2021, 2:22 PM
olasd renamed this task from Fix jenkins builds to Fix builds broken by mypy 0.920.Dec 16 2021, 2:23 PM
ardumont added a comment.EditedDec 16 2021, 2:28 PM

It was suggested to drop the type annotation in those files [1].

I'm currently planning to:

  • massively commit such changes
  • drop the copyright header (which are unnecessary in those files)
  • pin mypy to the current version (to avoid yet again those caveats later)

[1]

swh/__init__.py
swh/loader/__init__.py
ardumont added a revision: D6854: Drop unnecessary type annotation to fix mypy 0.920 issue.Dec 16 2021, 2:54 PM
ardumont added a commit: rDLDCVScbde981229dc: Pin mypy and drop type annotations which makes mypy unhappy.Dec 16 2021, 3:00 PM
aeviso added a commit: rDPROVbef0ab385dfa: Drop unnecessary type annotation to fix mypy 0.920 issue.Dec 16 2021, 3:06 PM
ardumont added a revision: D6855: Pin mypy and drop type annotations which makes mypy unhappy.Dec 16 2021, 3:19 PM
ardumont mentioned this in D6806: Fix typing which fails the build.Dec 16 2021, 3:23 PM
ardumont added a commit: rDWAPPS7ae38cf0568c: Pin mypy and drop type annotations which makes mypy unhappy.Dec 16 2021, 3:26 PM
ardumont mentioned this in rDJNL4e5e00988a4e: Pin mypy and drop type annotations which makes mypy unhappy\n\nRelated to T3812.
ardumont mentioned this in rDLDBASE32b2b7bba8b7: Pin mypy and drop type annotations which makes mypy unhappy.Dec 16 2021, 3:33 PM
ardumont mentioned this in rDLDG715fbe212d90: Pin mypy and drop type annotations which makes mypy unhappy.
ardumont mentioned this in rDLDHG2180cbbbbe60: Pin mypy and drop type annotations which makes mypy unhappy.Dec 16 2021, 3:36 PM
ardumont mentioned this in rDLDSVN196c9d596bb2: Pin mypy and drop type annotations which makes mypy unhappy.
ardumont mentioned this in rDOBJS4238095a6c9a: Pin mypy and drop type annotations which makes mypy unhappy.Dec 16 2021, 3:44 PM
ardumont mentioned this in rDOBJSRPLfa5dfe038234: Pin mypy and drop type annotations which makes mypy unhappy.
ardumont mentioned this in rDOPH7fd6dbac76e7: Pin mypy and drop type annotations which makes mypy unhappy.
ardumont mentioned this in rDTPL8e232a888066: Pin mypy and drop type annotations which makes mypy unhappy.
ardumont mentioned this in rDTSCN1b97932feb41: Pin mypy and drop type annotations which makes mypy unhappy.Dec 16 2021, 3:46 PM
ardumont added a revision: D6856: Pin mypy and drop type annotations which makes mypy unhappy.Dec 16 2021, 3:48 PM
ardumont mentioned this in rDSEA50fedafcf645: Pin mypy and drop type annotations which makes mypy unhappy.Dec 16 2021, 3:53 PM
ardumont added a commit: rDSCH559f3451c6c3: Pin mypy and drop type annotations which makes mypy unhappy.
ardumont mentioned this in rDVAUab311983a8dc: Pin mypy and drop type annotations which makes mypy unhappy.
ardumont mentioned this in rDWCLIb93e751f0d16: Pin mypy and drop type annotations which makes mypy unhappy.
ardumont mentioned this in rDMODabb089d4cf41: Pin mypy and drop type annotations which makes mypy unhappy.Dec 16 2021, 3:57 PM
ardumont mentioned this in rDAUTH0cd18057732b: Pin mypy and drop type annotations which makes mypy unhappy.Dec 16 2021, 4:02 PM
ardumont added a revision: D6857: Pin mypy and drop type annotations which makes mypy unhappy.Dec 16 2021, 4:03 PM
ardumont mentioned this in rDDATASET8d9fcb8edf6f: Pin mypy and drop type annotations which makes mypy unhappy.Dec 16 2021, 4:04 PM
ardumont mentioned this in rDDEP9807be11d043: Pin mypy and drop type annotations which makes mypy unhappy.
ardumont mentioned this in rDDOCa3aeb8ace15f: Pin mypy and drop type annotations which makes mypy unhappy.
ardumont mentioned this in rDFUSEe4e75768acf5: Pin mypy and drop type annotations which makes mypy unhappy.
ardumont mentioned this in rDICPc4f025e849c1: Pin mypy and drop type annotations which makes mypy unhappy.Dec 16 2021, 4:07 PM
ardumont mentioned this in rDCIDXfcfdc21f099a: Pin mypy and drop type annotations which makes mypy unhappy.Dec 16 2021, 4:09 PM
ardumont mentioned this in rDLSec7838123b0f: Pin mypy and drop type annotations which makes mypy unhappy.
ardumont added a commit: rDCORE4ff374f2f7a7: Pin mypy and drop type annotations which makes mypy unhappy.Dec 16 2021, 4:12 PM
ardumont mentioned this in rDCNTdb50e8217802: Pin mypy and drop type annotations which makes mypy unhappy.
ardumont mentioned this in rDGRPH4d36535f9e58: Pin mypy and drop type annotations which makes mypy unhappy.Dec 16 2021, 4:15 PM
ardumont added a revision: D6859: Pin mypy and drop type annotations which makes mypy unhappy.Dec 16 2021, 4:19 PM
ardumont added a commit: rDSTOf09a54d4f523: Pin mypy and drop type annotations which makes mypy unhappy.Dec 16 2021, 4:38 PM
ardumont mentioned this in rDMFCDae5dbe16ccff: Pin mypy and drop type annotations which makes mypy unhappy.Dec 16 2021, 4:47 PM
ardumont mentioned this in rTSBX113e0a5a9625: Pin mypy and drop type annotations which makes mypy unhappy.
ardumont added a subscriber: Alphare.Dec 16 2021, 4:56 PM

Issue upstream closed.
Mostly all swh repository (besides loader-bzs which @Alphare will take care of) are back to green now.

As mypy has been pinned, we should no longer be disturbed by such an upstream change.

We'll need to attend to upgrading mypy once in a while though somehow.
Using swh-environment/bin/change-all-repos will be helpful then.

ardumont closed this task as Resolved.Dec 16 2021, 4:56 PM
ardumont claimed this task.
gitlab-migration changed the task status from Resolved to Migrated.Jan 8 2023, 4:36 PM
gitlab-migration claimed this task.
gitlab-migration added a subscriber: gitlab-migration.

This task has been migrated to GitLab.

About · Developer information · Legal