This will allows to have green builds in jenkins.
[1] https://jenkins.softwareheritage.org/view/swh-draft/job/DLDBZR/job/tests/73/console
Differential D6806
Fix typing which fails the build ardumont on Dec 9 2021, 10:25 AM. Authored by
Details
This will allows to have green builds in jenkins. [1] https://jenkins.softwareheritage.org/view/swh-draft/job/DLDBZR/job/tests/73/console tox (happy?)
Diff Detail
Event TimelineComment Actions Rebase to check build triggering in jenkins actually happens Note: we added the required Language-python flag to the repository configuration Comment Actions Build has FAILED Link to build: https://jenkins.softwareheritage.org/job/DLDBZR/job/tests-on-diff/1/ Comment Actions Rebase to make the build ok now Note: Added the staging repository configuration to the repository Comment Actions Build has FAILED Patch application report for D6806 (id=24668)Rebasing onto 75bffa424f... Current branch diff-target is up to date. Changes applied before testcommit 198dd353701f5bc618d34cc4f473620e4e32ad6a Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com> Date: Thu Dec 9 10:24:04 2021 +0100 Fix typing which fails the build [1] https://jenkins.softwareheritage.org/view/swh-draft/job/DLDBZR/job/tests/73/console Link to build: https://jenkins.softwareheritage.org/job/DLDBZR/job/tests-on-diff/2/ Comment Actions
That's another error related to docs now. As @Alphare is currently working on the repository, i'll let this be. At least, @olasd and me fixed the repository's configuration so now new diff for that repository will build out of the box! Cheers, Comment Actions @Alphare heads up, it'd be great you could push a few commits to make the build green here (even if incomplete). I'm currently fighting the overall jenkins' redness (but this was was red already prior to the actual firefighting i'm doing). Please have a look at T3812 at some point to align the loader-bzr repository with what's described there. Cheers, Comment Actions I've been pushing to a draft, should I just publish the draft and then say it's still one in the comments?
Sure thing. Looking at it quickly it looks like a simple commit for that particular file should do the trick?
Comment Actions
sgtm
yes indeed. You can just do the same as this diff D6853 (including the mypy pinning that will prevent such surprise later ;) |