Page MenuHomeSoftware Heritage

Fix docstrings for Storage.add_{release,revision}.
ClosedPublic

Authored by vlorentz on Nov 19 2018, 2:34 PM.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Nov 19 2018, 2:34 PM
vlorentz planned changes to this revision.Nov 19 2018, 2:39 PM
vlorentz updated this revision to Diff 2130.Nov 19 2018, 2:46 PM
  • Fix date args as well.

Thanks.

I have one question/remark.

swh/storage/in_memory.py
292–293

Iterable[dict] or List[dict]?

ardumont added inline comments.Nov 20 2018, 5:37 PM
swh/storage/in_memory.py
292–293

ping ;)

vlorentz planned changes to this revision.Nov 20 2018, 7:34 PM
vlorentz updated this revision to Diff 2161.Nov 21 2018, 3:40 PM
  • Iterable[dict]
ardumont added inline comments.Nov 21 2018, 3:54 PM
swh/storage/in_memory.py
384–385

i did not mention this as this was implicit...
my bad...

This one would need to be changed as well.

swh/storage/storage.py
525–526

as well.

658–659

as well.

ardumont requested changes to this revision.Nov 22 2018, 10:32 AM

I fear that plain commenting is not enough for you to see, so i'll require the changes for you to see ;)

This revision now requires changes to proceed.Nov 22 2018, 10:32 AM

I fear that plain commenting is not enough for you to see, so i'll require the changes for you to see ;)

I get too many mails from the forge :/

"Require changes" is the right way to go with me, thanks

vlorentz updated this revision to Diff 2183.Nov 22 2018, 12:21 PM
ardumont accepted this revision.Nov 22 2018, 12:49 PM
This revision is now accepted and ready to land.Nov 22 2018, 12:49 PM
This revision was automatically updated to reflect the committed changes.