⚙ D676 Fix docstrings for Storage.add

vlorentz created this revision.Nov 19 2018, 2:34 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 19 2018, 2:34 PM

vlorentz planned changes to this revision.Nov 19 2018, 2:39 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/86/ for more details.

Harbormaster completed remote builds in B2451: Diff 2129.Nov 19 2018, 2:39 PM

Fix date args as well.

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/87/ for more details.

Harbormaster completed remote builds in B2452: Diff 2130.Nov 19 2018, 2:51 PM

Thanks.

I have one question/remark.

swh/storage/in_memory.py
284–285	Iterable[dict] or List[dict]?

ardumont added inline comments.Nov 20 2018, 5:37 PM

swh/storage/in_memory.py
284–285	ping ;)

vlorentz planned changes to this revision.Nov 20 2018, 7:34 PM

Iterable[dict]

ardumont added inline comments.Nov 21 2018, 3:54 PM

swh/storage/in_memory.py
377	i did not mention this as this was implicit... my bad... This one would need to be changed as well.
swh/storage/storage.py
527	as well.
659	as well.

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/99/ for more details.

Harbormaster completed remote builds in B2499: Diff 2161.Nov 21 2018, 3:58 PM

I fear that plain commenting is not enough for you to see, so i'll require the changes for you to see ;)

This revision now requires changes to proceed.Nov 22 2018, 10:32 AM

In D676#14423, @ardumont wrote:

I fear that plain commenting is not enough for you to see, so i'll require the changes for you to see ;)

I get too many mails from the forge :/

"Require changes" is the right way to go with me, thanks

Apply @ardumont's comments.

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/112/ for more details.

Harbormaster completed remote builds in B2523: Diff 2183.Nov 22 2018, 12:27 PM

ardumont accepted this revision.Nov 22 2018, 12:49 PM

This revision is now accepted and ready to land.Nov 22 2018, 12:49 PM

Closed by commit rDSTO90da2a9902f1: Fix docstrings for Storage.add_{release,revision}. (authored by vlorentz). · Explain WhyNov 22 2018, 1:10 PM

This revision was automatically updated to reflect the committed changes.

vlorentz mentioned this in D698: Use the new doc style for {revision,release}_add..Nov 22 2018, 2:37 PM

vlorentz mentioned this in rDSTOd8463b1ab18d: Use the new doc style for {revision,release}_add..Nov 29 2018, 2:40 PM

Fix docstrings for Storage.add_{release,revision}.
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 2161

swh/storage/in_memory.py

swh/storage/storage.py

Fix docstrings for Storage.add_{release,revision}.ClosedPublicActions