Page MenuHomeSoftware Heritage

Fix docstrings for Storage.add_{release,revision}.
ClosedPublic

Authored by vlorentz on Nov 19 2018, 2:34 PM.

Diff Detail

Repository
rDSTO Storage manager
Branch
doc-add-release-revision
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2499
Build 3090: tox-on-jenkinsJenkins
Build 3089: arc lint + arc unit

Event Timeline

Thanks.

I have one question/remark.

swh/storage/in_memory.py
284–285

Iterable[dict] or List[dict]?

swh/storage/in_memory.py
284–285

ping ;)

swh/storage/in_memory.py
377

i did not mention this as this was implicit...
my bad...

This one would need to be changed as well.

swh/storage/storage.py
527

as well.

659

as well.

I fear that plain commenting is not enough for you to see, so i'll require the changes for you to see ;)

This revision now requires changes to proceed.Nov 22 2018, 10:32 AM

I fear that plain commenting is not enough for you to see, so i'll require the changes for you to see ;)

I get too many mails from the forge :/

"Require changes" is the right way to go with me, thanks

This revision is now accepted and ready to land.Nov 22 2018, 12:49 PM
This revision was automatically updated to reflect the committed changes.