Page MenuHomeSoftware Heritage

Use the new doc style for {revision,release}_add.
ClosedPublic

Authored by vlorentz on Thu, Nov 22, 2:37 PM.

Details

Summary

Also fix the 'committer_date' on the PG Storage's revision_add,
that slipped through D676.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Thu, Nov 22, 2:37 PM
vlorentz updated this revision to Diff 2191.Thu, Nov 22, 2:38 PM
  • Shouldn't have committed that yet
vlorentz updated this revision to Diff 2192.Thu, Nov 22, 2:39 PM
  • fix branch
ardumont added inline comments.
swh/storage/in_memory.py
386–401

More than the type described here, svn, hg, etc...
We cannot really be exhaustive here, so we can make that examples, i think.

**type** (str): revision type (e.g git, tar, svn, hg, etc...)
douardda accepted this revision.Tue, Nov 27, 4:34 PM
douardda added a subscriber: douardda.

I'm ok with this Diff, but I'd appreciate a bit more details for this type argument.

swh/storage/in_memory.py
386–401

Ideally we'd like to have a simple way of knowing which values are possible for a given instance of the platform. Or at least add a few words telling where these accepted values come from (here, the list of supported loader, or more precisely the possible values of the 'type' key in the origin member of loader instances, which is a bit painful to explain is a docstring...) Not sure what's the best link to put here to reference the origin "schema", but i would be nice to have such a link.

Also applies to the same hunk on storage.py.

This revision is now accepted and ready to land.Tue, Nov 27, 4:34 PM
vlorentz marked an inline comment as done.Tue, Nov 27, 7:02 PM
vlorentz added inline comments.
ardumont added inline comments.Wed, Nov 28, 11:01 AM
swh/storage/in_memory.py
386–401

Yes, i do not see a better link than this one right now.

This revision was automatically updated to reflect the committed changes.