Page MenuHomeSoftware Heritage
Differential D648

tests: Add hypothesis profile to run tests faster depending on location
ClosedPublic
Actions

Authored by ardumont on Nov 12 2018, 2:17 PM.

Details

Reviewers
douardda
Group Reviewers
Reviewers
Commits
rDSTOc76de7ad560e: tests: Use fast/slow profile names
rDSTOe3dd0b48e7c6: tox: Define a py3-slow environment
rDSTOc484165d72a0: Makefile: Adapt makefile to use the dev profile
rDSTO560d7fa593c5: tests: Use hypothesis profile mechanism to configure samples size
rDSTO157b4abb94b1: tests: Decrease generation sample to make tests faster
Summary

Hypothesis allows different settings through profile. In our case,
that would allows us to generate smaller samples on the ci.

This diff provides 2 profiles:

  • dev: larger samples
  • ci: lesser samples

That should be the other way around (largest on ci) but for now, that
will do.

[1] https://hypothesis.readthedocs.io/en/latest/settings.html#settings-profiles

Depends on D647

Test Plan
  • tox
  • tox -e py3-slow
  • make test (old way?)

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Nov 12 2018, 2:17 PM
ardumont mentioned this in D646: tests: Add test content generation util function.Nov 12 2018, 2:18 PM
Harbormaster failed remote builds in B2327: Diff 2018!Nov 12 2018, 2:39 PM
swh-public-ci added a subscriber: swh-public-ci.Nov 12 2018, 2:39 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/62/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/62/console

ardumont added a comment.Nov 12 2018, 2:48 PM

Build has FAILED

stacked diff, you cannot build it successfully.

ardumont updated this revision to Diff 2024.Nov 12 2018, 2:53 PM
  • Makefile: Adapt makefile to use dev profile
Harbormaster failed remote builds in B2335: Diff 2024!Nov 12 2018, 2:53 PM
swh-public-ci added a comment.Nov 12 2018, 2:53 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/67/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/67/console

ardumont edited the test plan for this revision. (Show Details)Nov 12 2018, 2:54 PM
ardumont retitled this revision from tests: Add hypothesis profile to run tests to tests: Add hypothesis profile to run tests faster depending on location.Nov 12 2018, 3:02 PM
douardda requested changes to this revision.EditedNov 13 2018, 10:54 AM

I would rather name these profiles after their nature rather than their usage, ie.

slim/fat or quick/slow instead of dev/ci

This revision now requires changes to proceed.Nov 13 2018, 10:54 AM
ardumont added a comment.Nov 13 2018, 11:56 AM

I would rather name these profiles after their nature rather than their usage

Yes, sounds right!
(on it)

ardumont updated this revision to Diff 2032.Nov 13 2018, 11:57 AM
  • tests: Use fast/slow profile names
Harbormaster failed remote builds in B2348: Diff 2032!Nov 13 2018, 11:57 AM
swh-public-ci added a comment.Nov 13 2018, 11:57 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/68/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/68/console

douardda requested changes to this revision.Nov 13 2018, 12:06 PM
douardda added inline comments.
tox.ini
9–11 ↗(On Diff #2032)

might be useful to add a py3-slow tox env, I guess.

This revision now requires changes to proceed.Nov 13 2018, 12:06 PM
ardumont marked an inline comment as done.Nov 13 2018, 5:49 PM
ardumont added inline comments.
tox.ini
9–11 ↗(On Diff #2032)

Good idea.

And this way, i learn tox stuff, cool.

Thanks.

ardumont updated this revision to Diff 2033.Nov 13 2018, 5:53 PM
  • tox.ini: Add py3-slow environment to use the slow profile
ardumont marked 2 inline comments as done.Nov 13 2018, 5:54 PM
ardumont added inline comments.
tox.ini
9–11 ↗(On Diff #2032)

tox -e py3-slow

Harbormaster failed remote builds in B2349: Diff 2033!Nov 13 2018, 5:54 PM
swh-public-ci added a comment.Nov 13 2018, 5:54 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/69/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/69/console

ardumont edited the test plan for this revision. (Show Details)Nov 13 2018, 5:55 PM
vlorentz added a reviewer: Reviewers.Nov 14 2018, 11:48 AM
ardumont updated this revision to Diff 2050.Nov 14 2018, 3:21 PM

Rebase

Harbormaster failed remote builds in B2367: Diff 2050!Nov 14 2018, 3:21 PM
swh-public-ci added a comment.Nov 14 2018, 3:21 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/76/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/76/console

ardumont updated this revision to Diff 2051.Nov 14 2018, 3:24 PM
  • tox: Define a py3-slow environment

Again (lost one commit here in the rebase workflow)

Harbormaster completed remote builds in B2368: Diff 2051.Nov 14 2018, 3:24 PM
douardda accepted this revision.Nov 14 2018, 3:54 PM
This revision is now accepted and ready to land.Nov 14 2018, 3:54 PM
Closed by commit rDSTO157b4abb94b1: tests: Decrease generation sample to make tests faster (authored by ardumont). · Explain WhyNov 14 2018, 3:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
storage/
tests/
6 lines

Diff 2062

View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal