Page MenuHomeSoftware Heritage
Differential D647

storage: Open content_get_range storage endpoint
ClosedPublic
Actions

Authored by ardumont on Nov 12 2018, 11:41 AM.

Details

Reviewers
olasd
vlorentz
Group Reviewers
Reviewers
Commits
rDSTOfb14ad046f87: tests: Add docstring to test to detail what's tested
rDSTO13d8a9aa4b56: tests: Move property_based marker to toplevel test class
rDSTO9fe5c7fa5142: tests: Use sorted
rDSTO751542bdac4f: storage: Open content_get_range endpoint
Summary

This allows to retrieve contents from within a range.
The endpoint is paginated.

Tests are using the hypothesis module and reuse the initial work on
D646.

Depends on D646

Test Plan

tox

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont updated this revision to Diff 2015.Nov 12 2018, 11:41 AM
ardumont created this revision.

Use the right origin commit.

ardumont updated this revision to Diff 2016.Nov 12 2018, 11:47 AM

Fix:

  • spurious print statements
  • wrong docstring conventions
ardumont updated this revision to Diff 2017.Nov 12 2018, 11:49 AM

Again use the right original commit!

ardumont added a child revision: D648: tests: Add hypothesis profile to run tests faster depending on location.Nov 12 2018, 2:17 PM
Harbormaster failed remote builds in B2323: Diff 2014!Nov 12 2018, 2:38 PM
swh-public-ci added a subscriber: swh-public-ci.Nov 12 2018, 2:38 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/59/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/59/console

Harbormaster failed remote builds in B2326: Diff 2017!Nov 12 2018, 2:39 PM
swh-public-ci added a comment.Nov 12 2018, 2:39 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/61/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/61/console

Harbormaster failed remote builds in B2324: Diff 2015!Nov 12 2018, 2:40 PM
swh-public-ci added a comment.Nov 12 2018, 2:40 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/64/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/64/console

Harbormaster failed remote builds in B2325: Diff 2016!Nov 12 2018, 2:40 PM
swh-public-ci added a comment.Nov 12 2018, 2:40 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/65/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/65/console

ardumont added a comment.Nov 12 2018, 2:48 PM

Build has FAILED

stacked diff, you cannot build it successfully.

vlorentz added a reviewer: Reviewers.Nov 14 2018, 11:48 AM
vlorentz requested changes to this revision.Nov 14 2018, 2:29 PM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/storage/storage.py
261

Why +1?

swh/storage/tests/test_storage.py
1909

Nitpick: get_sha1s = sorted(c['sha1'] for c in contents)

1925

I don't think this properly tests contents. What if contents[0] is an empty dict?

1958

Same comment as above

This revision now requires changes to proceed.Nov 14 2018, 2:29 PM
ardumont marked 2 inline comments as done.Nov 14 2018, 3:11 PM
ardumont added inline comments.
swh/storage/storage.py
261

To retrieve the next content_id when checking for the boundary limit.

swh/storage/tests/test_storage.py
1925

As explained in prior diff D646#inline-3344, cannot happen here.

ardumont marked an inline comment as done.Nov 14 2018, 3:12 PM
ardumont added inline comments.
swh/storage/tests/test_storage.py
1909

right.

ardumont updated this revision to Diff 2047.Nov 14 2018, 3:14 PM

Adapt according to review

  • storage: Open content_get_range endpoint
  • tests: Use sorted

(and rebase interactively)

Harbormaster failed remote builds in B2364: Diff 2047!Nov 14 2018, 3:14 PM
swh-public-ci added a comment.Nov 14 2018, 3:14 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/73/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/73/console

ardumont updated this revision to Diff 2049.Nov 14 2018, 3:20 PM

Add missing commits from the prior rebase instructions (T.T)

  • tests: Move property_based marker to toplevel test class
  • tests: Add docstring to test to detail what's tested
Harbormaster failed remote builds in B2366: Diff 2049!Nov 14 2018, 3:20 PM
swh-public-ci added a comment.Nov 14 2018, 3:20 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/75/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/75/console

vlorentz accepted this revision.Nov 14 2018, 3:22 PM
This revision is now accepted and ready to land.Nov 14 2018, 3:22 PM
Closed by commit rDSTO751542bdac4f: storage: Open content_get_range endpoint (authored by ardumont). · Explain WhyNov 14 2018, 3:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
storage/
api/
5 lines
6 lines
14 lines
35 lines
tests/
7 lines
71 lines

Diff 2061

View Options

swh/storage/api/client.py

Loading...
View Options

swh/storage/api/server.py

Loading...
View Options

swh/storage/db.py

Loading...
View Options

swh/storage/storage.py

Loading...
View Options

swh/storage/tests/__init__.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal